export: add extras flag and exclude optional packages by default#1285
Merged
sdispater merged 1 commit intopython-poetry:developfrom Aug 8, 2019
Merged
export: add extras flag and exclude optional packages by default#1285sdispater merged 1 commit intopython-poetry:developfrom
sdispater merged 1 commit intopython-poetry:developfrom
Conversation
3 tasks
2 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1284 for issue description and feature suggestion.
This PR introduces the
--extrasflag forpoetry export, and changes the default behaviour to exclude optional packages from the exportedrequirements.txtfile.This is consistent with existing behaviour for two reasons:
exportalready excludesdevpackages by default--extrasis required byinstallto install optional packagesWhile this is a breaking change,
exporthas not currently been released, so there should be no barrier to this making it into version 1 if the feature is accepted.Feedback time!