Skip to content

Comments

Update to dulwich 1.0.0#10701

Merged
radoering merged 1 commit intopython-poetry:mainfrom
hroncok:dulwich1
Jan 22, 2026
Merged

Update to dulwich 1.0.0#10701
radoering merged 1 commit intopython-poetry:mainfrom
hroncok:dulwich1

Conversation

@hroncok
Copy link
Contributor

@hroncok hroncok commented Jan 21, 2026 •
edited by sourcery-ai bot
Loading

From the release notes:

From here on, Dulwich will not break backwards compatibility until 2.0

jelmer/dulwich@ca9de6d

Pull Request Check List

  • There is no changed code.
  • There is no changed code.

Summary by Sourcery

Build:

  • Broaden dulwich version constraint from <0.26.0 to <2 to support dulwich 1.0 and later 1.x releases.

@hroncok
Update to dulwich 1.0.0
1409176 
From the release notes:

> From here on, Dulwich will not break backwards compatibility until 2.0

jelmer/dulwich@ca9de6d
@sourcery-ai
Copy link

sourcery-ai bot commented Jan 21, 2026 •
edited
Loading

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Update the dulwich dependency constraint to allow version 1.x (up to but not including 2.0) and refresh the lockfile accordingly.

File-Level Changes

Change Details Files
Relax dulwich dependency upper bound to permit all versions <2.0 and update the lockfile resolution.
  • Broaden dulwich version specifier from <0.26.0 to <2 to allow 1.x releases while keeping the same minimum version.
  • Regenerate poetry.lock so that it is consistent with the new dulwich constraint and resolved dependency graph.
 pyproject.toml
poetry.lock

Possibly linked issues

  • #(none provided): Both concern dulwich compatibility; PR updates dependency range to versions that avoid the reported 0.24.9 issue.
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Jan 21, 2026
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Given Dulwich’s backward-compatibility guarantee only starts at 1.0.0, consider bumping the lower bound to >=1.0.0 if you intend to rely on stable APIs while expanding the upper bound to <2.
Prompt for AI Agents 
Please address the comments from this code review:

## Overall Comments
- Given Dulwich’s backward-compatibility guarantee only starts at 1.0.0, consider bumping the lower bound to `>=1.0.0` if you intend to rely on stable APIs while expanding the upper bound to `<2`.
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@hroncok
Copy link
Contributor Author

hroncok commented Jan 21, 2026

Given Dulwich’s backward-compatibility guarantee only starts at 1.0.0, consider bumping the lower bound to >=1.0.0

Happy to do that if the poetry maintainers want to. But it works with the previous version as well.

@radoering
Copy link
Member

radoering commented Jan 22, 2026

I think it is fine to only bump the upper bound. Apparently, there is no breaking change that hits us between 0.25 and 1.0 and I do not expect more 0.x versions in the future.

@radoering radoering merged commit 4a8031f into python-poetry:main Jan 22, 2026
54 checks passed
@jelmer
Copy link
Contributor

jelmer commented Jan 22, 2026

I think it is fine to only bump the upper bound. Apparently, there is no breaking change that hits us between 0.25 and 1.0 and I do not expect more 0.x versions in the future.

Indeed, there will not be any more 0.x versions with one caveat: if there are security issues or grave C Git interoperability issues (new release of C Git write repositories in a way that breaks Dulwich) I will consider releasing another 0.25.x - but also without making any backwards incompatible changes.

@hroncok hroncok deleted the dulwich1 branch January 22, 2026 12:46
@radoering radoering mentioned this pull request Feb 1, 2026
Merged
nothing-991 pushed a commit to nothing-991/python-poetry that referenced this pull request Feb 3, 2026
@hroncok @nothing-991
Update to dulwich 1.0.0 (python-poetry#10701)
8fc5583 
From the release notes:

> From here on, Dulwich will not break backwards compatibility until 2.0
@github-actions
Copy link

github-actions bot commented Feb 22, 2026

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@radoering radoering radoering approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hroncok @radoering @jelmer