env activate: fallback to POSIX compatible builtin by mymedia2 · Pull Request #10696 · python-poetry/poetry

mymedia2 · 2026-01-17T14:50:57Z

Pull Request Check List

Added tests for changed code.
Updated documentation for changed code.

Rationale

POSIX.1-2024 and earlier standards define the dot special built-in utility. Its command name consists of a single character .. Execution of the source command is explicitly unspecified by the standard. Most shells provide this convenient alias, some do not. Notable exception is dash, Debian Almquist shell, which mainly conforms to the POSIX standard and intentionally stays away from bashisms. BusyBox incorporates another ash variant in which the source command may be disabled at configuration time.

In this pull request, poetry env activate prints the source command only in shells that guarantied to support it, that is Bash, fish, mksh (MirBSD Korn shell), and Zsh. But fish already has an if branch.

I tested the changes manually in Alpine Docker with above mentioned shells. And dash no longer throws the following error and actually activates environment if any.

# eval $(poetry env activate)
dash: 1: eval: source: not found

Summary by Sourcery

Adjust virtual environment activation command selection to be POSIX-compatible across different shells.

Bug Fixes:

Use the POSIX-compliant '.' builtin instead of 'source' for shells that do not guarantee support for the 'source' command, preventing activation failures in such environments.

Tests:

Extend env activation tests to cover dash and validate the correct activation command per shell.

sourcery-ai · 2026-01-17T14:51:03Z

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts poetry env activate to emit a POSIX-compliant activation command by using source only for shells that are known to support it, and falling back to . for others, with corresponding test coverage added.

Class diagram for EnvActivateCommand activation logic

classDiagram
  class EnvActivateCommand {
    +_get_activate_command(env, shell) str
  }

  class Env {
    +bin_dir
  }

  EnvActivateCommand ..> Env : uses

File-Level Changes

Change	Details	Files
Make env activation command selection shell-aware, using `source` only for specific shells and POSIX `.` as the fallback.	Refined `_get_activate_command` to map PowerShell and cmd to `.` with their respective activation scripts as before. Changed the generic shell branch to use `source` only when the shell is one of `bash`, `mksh`, or `zsh`. Introduced a final fallback branch that uses POSIX `.` with the `activate` script for all other shells.	`src/poetry/console/commands/env/activate.py`
Extend activation tests to cover the new shell-specific behavior and the POSIX fallback.	Added a `dash` case to the parametrized tests expecting the `.` command and no extension. Verified that existing cases for `bash`, `zsh`, and `fish` still assert `source` or fish-specific behavior with proper extensions.	`tests/console/commands/env/test_activate.py`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai

Hey - I've found 1 issue

Prompt for AI Agents

Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `tests/console/commands/env/test_activate.py:27` </location>
<code_context>
 @pytest.mark.parametrize(
     "shell, command, ext",
     (
+        ("dash", ".", ""),
         ("bash", "source", ""),
         ("zsh", "source", ""),
</code_context>

<issue_to_address>
**suggestion (testing):** Add a parametrized case for `mksh` to cover the new `elif shell in ["bash", "mksh", "zsh"]` branch

Since `mksh` is now handled alongside `bash` and `zsh` in production, this test should also include `mksh` (e.g. `("mksh", "source", "")`) to confirm it follows the `source activate` path instead of the POSIX `.` fallback.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

tests/console/commands/env/test_activate.py

radoering

Thank you for the detailed explanation. 👍

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [poetry](https://github.com/python-poetry/poetry) ([changelog](https://python-poetry.org/history/)) | minor | ` 2.2.1` -> `2.3.0` | --- ### Release Notes <details> <summary>python-poetry/poetry (poetry)</summary> ### [`v2.3.0`](https://github.com/python-poetry/poetry/blob/HEAD/CHANGELOG.md#230---2026-01-18) [Compare Source](python-poetry/poetry@2.2.1...2.3.0) ##### Added - **Add support for exporting `pylock.toml` files with `poetry-plugin-export`** ([#10677](python-poetry/poetry#10677)). - Add support for specifying build constraints for dependencies ([#10388](python-poetry/poetry#10388)). - Add support for publishing artifacts whose version is determined dynamically by the build-backend ([#10644](python-poetry/poetry#10644)). - Add support for editable project plugins ([#10661](python-poetry/poetry#10661)). - Check `requires-poetry` before any other validation ([#10593](python-poetry/poetry#10593)). - Validate the content of `project.readme` when running `poetry check` ([#10604](python-poetry/poetry#10604)). - Add the option to clear all caches by making the cache name in `poetry cache clear` optional ([#10627](python-poetry/poetry#10627)). - Automatically update the cache for packages where the locked files differ from cached files ([#10657](python-poetry/poetry#10657)). - Suggest to clear the cache if running a command with `--no-cache` solves an issue ([#10585](python-poetry/poetry#10585)). - Propose `poetry init` when trying `poetry new` for an existing directory ([#10563](python-poetry/poetry#10563)). - Add support for `poetry publish --skip-existing` for new Nexus OSS versions ([#10603](python-poetry/poetry#10603)). - Show Poetry's own Python's path in `poetry debug info` ([#10588](python-poetry/poetry#10588)). ##### Changed - **Drop support for Python 3.9** ([#10634](python-poetry/poetry#10634)). - **Change the default of `installer.re-resolve` from `true` to `false`** ([#10622](python-poetry/poetry#10622)). - **PEP 735 dependency groups are considered in the lock file hash** ([#10621](python-poetry/poetry#10621)). - Deprecate `poetry.utils._compat.metadata`, which is sometimes used in plugins, in favor of `importlib.metadata` ([#10634](python-poetry/poetry#10634)). - Improve managing free-threaded Python versions with `poetry python` ([#10606](python-poetry/poetry#10606)). - Prefer JSON API to HTML API in legacy repositories ([#10672](python-poetry/poetry#10672)). - When running `poetry init`, only add the readme field in the `pyproject.toml` if the readme file exists ([#10679](python-poetry/poetry#10679)). - Raise an error if no hash can be determined for any distribution link of a package ([#10673](python-poetry/poetry#10673)). - Require `dulwich>=0.25.0` ([#10674](python-poetry/poetry#10674)). ##### Fixed - Fix an issue where `poetry remove` did not work for PEP 735 dependency groups with `include-group` items ([#10587](python-poetry/poetry#10587)). - Fix an issue where `poetry remove` caused dangling `include-group` references in PEP 735 dependency groups ([#10590](python-poetry/poetry#10590)). - Fix an issue where `poetry add` did not work for PEP 735 dependency groups with `include-group` items ([#10636](python-poetry/poetry#10636)). - Fix an issue where PEP 735 dependency groups were not considered in the lock file hash ([#10621](python-poetry/poetry#10621)). - Fix an issue where wrong markers were locked for a dependency that was required by several groups with different markers ([#10613](python-poetry/poetry#10613)). - Fix an issue where non-deterministic markers were created in a method used by `poetry-plugin-export` ([#10667](python-poetry/poetry#10667)). - Fix an issue where wrong wheels were chosen for installation in free-threaded Python environments if Poetry itself was not installed with free-threaded Python ([#10614](python-poetry/poetry#10614)). - Fix an issue where `poetry publish` used the metadata of the project instead of the metadata of the build artifact ([#10624](python-poetry/poetry#10624)). - Fix an issue where `poetry env use` just used another Python version instead of failing when the requested version was not supported by the project ([#10685](python-poetry/poetry#10685)). - Fix an issue where `poetry env activate` returned the wrong command for `dash` ([#10696](python-poetry/poetry#10696)). - Fix an issue where `data-dir` and `python.installation-dir` could not be set ([#10595](python-poetry/poetry#10595)). - Fix an issue where Python and pip executables were not correctly detected on Windows ([#10645](python-poetry/poetry#10645)). - Fix an issue where invalid template variables in `virtualenvs.prompt` caused an incomprehensible error message ([#10648](python-poetry/poetry#10648)). ##### Docs - Add a warning about `~/.netrc` for Poetry credential configuration ([#10630](python-poetry/poetry#10630)). - Clarify that the local configuration takes precedence over the global configuration ([#10676](python-poetry/poetry#10676)). - Add an explanation in which cases `packages` are automatically detected ([#10680](python-poetry/poetry#10680)). ##### poetry-core ([`2.3.0`](https://github.com/python-poetry/poetry-core/releases/tag/2.3.0)) - Normalize versions ([#893](python-poetry/poetry-core#893)). - Fix an issue where unsatisfiable requirements did not raise an error ([#891](python-poetry/poetry-core#891)). - Fix an issue where the implicit main group did not exist if it was explicitly declared as not having any dependencies ([#892](python-poetry/poetry-core#892)). - Fix an issue where `python_full_version` markers with pre-release versions were parsed incorrectly ([#893](python-poetry/poetry-core#893)). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.walbeck.it/walbeck-it/docker-python-poetry/pulls/1654 Co-authored-by: renovate-bot <[email protected]> Co-committed-by: renovate-bot <[email protected]>

github-actions · 2026-02-18T00:46:18Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

sourcery-ai bot reviewed Jan 17, 2026

View reviewed changes

tests/console/commands/env/test_activate.py Show resolved Hide resolved

radoering approved these changes Jan 18, 2026

View reviewed changes

env activate: fallback to POSIX compatible builtin

857777b

radoering force-pushed the patch-1 branch from 48a40b8 to 857777b Compare January 18, 2026 06:24

radoering enabled auto-merge (squash) January 18, 2026 06:27

radoering merged commit c6d3537 into python-poetry:main Jan 18, 2026
54 checks passed

radoering mentioned this pull request Jan 18, 2026

release: bump version to 2.3.0 #10695

Merged

nothing-991 pushed a commit to nothing-991/python-poetry that referenced this pull request Feb 3, 2026

env activate: fallback to POSIX compatible builtin (python-poetry#10696)

e97537e

github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

env activate: fallback to POSIX compatible builtin#10696

env activate: fallback to POSIX compatible builtin#10696
radoering merged 1 commit intopython-poetry:mainfrom
mymedia2:patch-1

mymedia2 commented Jan 17, 2026 •

edited by sourcery-ai bot

Loading

Uh oh!

sourcery-ai bot commented Jan 17, 2026 •

edited

Loading

Reviewer's Guide

Class diagram for EnvActivateCommand activation logic

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai bot left a comment

Uh oh!

Uh oh!

radoering left a comment

Uh oh!

Uh oh!

github-actions bot commented Feb 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

mymedia2 commented Jan 17, 2026 • edited by sourcery-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Check List

Rationale

Summary by Sourcery

Uh oh!

sourcery-ai bot commented Jan 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

Class diagram for EnvActivateCommand activation logic

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

radoering left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Feb 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mymedia2 commented Jan 17, 2026 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Jan 17, 2026 •

edited

Loading