Support new Nexus OSS versions for --skip-existing argument logic#10603
Merged
radoering merged 2 commits intopython-poetry:mainfrom Nov 1, 2025
Merged
Support new Nexus OSS versions for --skip-existing argument logic#10603radoering merged 2 commits intopython-poetry:mainfrom
radoering merged 2 commits intopython-poetry:mainfrom
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR extends the Class diagram for updated _is_file_exists_error method logicclassDiagram
class Uploader {
_is_file_exists_error(response: requests.Response) bool
}
Uploader : +_is_file_exists_error checks for
Uploader : - status == 400 and "already exist" in reason_and_text
Uploader : - status == 400 and "updating asset" in reason_and_text
Uploader : + status == 400 and "cannot be updated" in reason_and_text
Uploader : - status == 403 and "overwrite artifact" in reason_and_text
Uploader : - status == 403 and "overwrite artifact" in reason_and_text
Uploader : - status == 403 and "overwrite artifact" in reason_and_text
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Consider extracting these repetitive error-pattern checks into a centralized list or configuration so adding future cases like “cannot be updated” stays maintainable.
- Update the _is_file_exists_error docstring (or add an inline comment) to note that Nexus OSS’s “cannot be updated” message is now handled by this logic.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider extracting these repetitive error-pattern checks into a centralized list or configuration so adding future cases like “cannot be updated” stays maintainable.
- Update the _is_file_exists_error docstring (or add an inline comment) to note that Nexus OSS’s “cannot be updated” message is now handled by this logic.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
radoering
requested changes
Oct 31, 2025
Member
radoering
left a comment
There was a problem hiding this comment.
Can you add a test with the full text here, please?
poetry/tests/publishing/test_uploader.py
Lines 125 to 129 in 477b54b
6abc8d5 to
8ee51b1
Compare
radoering
approved these changes
Nov 1, 2025
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: #10602
Summary by Sourcery
Enhancements: