Show Python path for Poetry in debug info#10588
Show Python path for Poetry in debug info#10588radoering merged 3 commits intopython-poetry:mainfrom
debug info#10588Conversation
Reviewer's GuideExtends the Sequence diagram for enhanced debug info output in handle()sequenceDiagram
participant User as actor User
participant DebugInfoCommand
participant sys
participant Poetry
User->>DebugInfoCommand: invoke handle()
DebugInfoCommand->>Poetry: get VERSION
DebugInfoCommand->>sys: get python version
DebugInfoCommand->>sys: get prefix (env path)
DebugInfoCommand->>sys: get executable
DebugInfoCommand-->>User: print debug info (Version, Python, Path, Executable)
Class diagram for updated DebugInfoCommand outputclassDiagram
class DebugInfoCommand {
+handle() int
-poetry: Poetry
}
class Poetry {
+VERSION: str
}
DebugInfoCommand --> Poetry: uses
%% Updated output attributes in handle()
%% Now includes Version, Python, Path, Executable
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `tests/console/commands/debug/test_info.py:18` </location>
<code_context>
</code_context>
<issue_to_address>
**issue (code-quality):** Don't import test modules. ([`dont-import-test-modules`](https://docs.sourcery.ai/Reference/Rules-and-In-Line-Suggestions/Python/Default-Rules/dont-import-test-modules))
<details><summary>Explanation</summary>Don't import test modules.
Tests should be self-contained and don't depend on each other.
If a helper function is used by multiple tests,
define it in a helper module,
instead of importing one test from the other.
</details>
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
radoering
left a comment
There was a problem hiding this comment.
LGTM except for the failing Windows tests. Can you take a look, please?
|
Hmm. I took a look at the errors, and tried to resolve them. Not sure if I totally have. Here's the original error: So here, the error appears to be with the output from the That being said, I tried to be more careful with paths, to better support Windows. Happy to take pointers. I rebased onto main and added a commit. There are now different failing tests, which seem to be unrelated to the changes here. Any thoughts on how I should proceed? |
You mock
Just wait and re-run. That was actions/runner-images#13341 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Pull Request Check List
Resolves: #10559
Summary
Adds the executable and environment path for the Python executable running Poetry to
poetry self debug.I believe the
syscalls are correct, but happy to adjust as needed. Also, I did not see any docs that required updating.Summary by Sourcery
Include the Python environment path and executable in the output of
poetry self debug.Enhancements:
Tests: