installer: improve support of Python pre-releases by radoering · Pull Request #10516 · python-poetry/poetry

radoering · 2025-08-25T09:18:58Z

Closes: python-poetry/poetry-core#879
Closes: #10515

This is a less pervasive solution for the issue described in python-poetry/poetry-core#879:

https://github.com/python-poetry/poetry/actions/runs/17171517004/job/48721759731?pr=10514 (failure in tests/utils/test_isolated_build.py::test_isolated_env_install_discards_requirements_not_needed_by_env with Python 3.14rc2) shows that our installer does not handle environments of Python pre-release versions well. A dependency with the marker python_version == "3.14" is not installed because it is translated into a Python constraint >=3.14,<3.15, which does not allow Python 3.14rc2.

This PR just considers the stable part of the Python version of the environment to decide if dependencies should be installed. While the solution in python-poetry/poetry-core#879 seems (at least partially) more correct, it results in inconsistencies shown in the poetry-plugin-export tests in #10515.

Of course, this solution will break the evaluation of certain python_full_version markers, which explicitly reference a pre-release. However, I suppose such markers are not commonly used so that this might be acceptable.

Summary by Sourcery

Bug Fixes:

Compute the environment's python constraint from the stable part of python_full_version to allow dependencies with python_version markers to install on pre-release interpreters.

sourcery-ai · 2025-08-25T09:19:04Z

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Pull request adjusts how the installer computes the Python version constraint, switching to the stable version to better support pre-release interpreters (e.g., 3.14rc2).

Class diagram for updated Provider.use_environment method

classDiagram
    class Provider {
        - _env: Env
        - _package_python_constraint: Version
        + use_environment(env: Env): Iterator[Provider]
    }
    class Env {
        + marker_env: dict
    }
    class Version {
        + parse(version_str: str): Version
        + stable: Version
    }
    Provider --> Env : uses
    Provider --> Version : uses
    Env --> "marker_env" dict : contains
    Version <|-- Version.stable : property

File-Level Changes

Change	Details	Files
Use stable Python version for dependency markers in environment constraints	Parse full Python version and extract its stable component Replace direct use of python_full_version with its stable attribute Add comment explaining rationale for using stable version	`src/poetry/puzzle/provider.py`

Possibly linked issues

tests: adapt expectations to poetry-core#879 #10515: The PR changes version parsing to use the stable part of Python versions, resolving the issue with pre-releases.
tests: adapt expectations to poetry-core#879 #10515: The PR changes the version parsing to fix dependency installation for Python pre-release versions, addressing the test failure.

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai

Hey there - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [poetry](https://github.com/python-poetry/poetry) ([changelog](https://python-poetry.org/history/)) | minor | `2.1.4` -> `2.2.1` | --- ### Release Notes <details> <summary>python-poetry/poetry (poetry)</summary> ### [`v2.2.1`](https://github.com/python-poetry/poetry/blob/HEAD/CHANGELOG.md#221---2025-09-21) [Compare Source](python-poetry/poetry@2.2.0...2.2.1) ##### Fixed - Fix an issue where `poetry self show` failed with a message about an invalid output format ([#10560](python-poetry/poetry#10560)). ##### Docs - Remove outdated statements about dependency groups ([#10561](python-poetry/poetry#10561)). ##### poetry-core ([`2.2.1`](https://github.com/python-poetry/poetry-core/releases/tag/2.2.1)) - Fix an issue where it was not possible to declare a PEP 735 dependency group as optional ([#888](python-poetry/poetry-core#888)). ### [`v2.2.0`](https://github.com/python-poetry/poetry/blob/HEAD/CHANGELOG.md#220---2025-09-14) [Compare Source](python-poetry/poetry@2.1.4...2.2.0) ##### Added - **Add support for nesting dependency groups** ([#10166](python-poetry/poetry#10166)). - **Add support for PEP 735 dependency groups** ([#10130](python-poetry/poetry#10130)). - **Add support for PEP 639 license clarity** ([#10413](python-poetry/poetry#10413)). - Add a `--format` option to `poetry show` to alternatively output json format ([#10487](python-poetry/poetry#10487)). - Add official support for Python 3.14 ([#10514](python-poetry/poetry#10514)). ##### Changed - **Normalize dependency group names** ([#10387](python-poetry/poetry#10387)). - Change `installer.no-binary` and `installer.only-binary` so that explicit package names will take precedence over `:all:` ([#10278](python-poetry/poetry#10278)). - Improve log output during `poetry install` when a wheel is built from source ([#10404](python-poetry/poetry#10404)). - Improve error message in case a file lock could not be acquired while cloning a git repository ([#10535](python-poetry/poetry#10535)). - Require `dulwich>=0.24.0` ([#10492](python-poetry/poetry#10492)). - Allow `virtualenv>=20.33` again ([#10506](python-poetry/poetry#10506)). - Allow `findpython>=0.7` ([#10510](python-poetry/poetry#10510)). - Allow `importlib-metadata>=8.7` ([#10511](python-poetry/poetry#10511)). ##### Fixed - Fix an issue where `poetry new` did not create the project structure in an existing empty directory ([#10431](python-poetry/poetry#10431)). - Fix an issue where a dependency that was required for a specific Python version was not installed into an environment of a pre-release Python version ([#10516](python-poetry/poetry#10516)). ##### poetry-core ([`2.2.0`](https://github.com/python-poetry/poetry-core/releases/tag/2.2.0)) - Deprecate table values and values that are not valid SPDX expressions for `[project.license]` ([#870](python-poetry/poetry-core#870)). - Fix an issue where explicitly included files that are in `.gitignore` were not included in the distribution ([#874](python-poetry/poetry-core#874)). - Fix an issue where marker operations could result in invalid markers ([#875](python-poetry/poetry-core#875)). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.walbeck.it/walbeck-it/docker-python-poetry/pulls/1588 Co-authored-by: renovate-bot <[email protected]> Co-committed-by: renovate-bot <[email protected]>

github-actions · 2025-09-27T00:31:15Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

sourcery-ai bot reviewed Aug 25, 2025

View reviewed changes

installer: improve support of Python pre-releases

f65bc66

radoering force-pushed the improve-python-prerelease-support-installer branch from cc8fc88 to f65bc66 Compare August 27, 2025 08:15

radoering merged commit 2b3941a into python-poetry:main Aug 27, 2025
53 checks passed

radoering mentioned this pull request Sep 13, 2025

release: bump version to 2.2.0 #10546

Merged

github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2025

radoering deleted the improve-python-prerelease-support-installer branch December 13, 2025 17:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

installer: improve support of Python pre-releases#10516

installer: improve support of Python pre-releases#10516
radoering merged 1 commit intopython-poetry:mainfrom
radoering:improve-python-prerelease-support-installer

radoering commented Aug 25, 2025 •

edited by sourcery-ai bot

Loading

Uh oh!

sourcery-ai bot commented Aug 25, 2025 •

edited

Loading

Reviewer's Guide

Class diagram for updated Provider.use_environment method

File-Level Changes

Possibly linked issues

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai bot left a comment

Uh oh!

Uh oh!

github-actions bot commented Sep 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Comments

Conversation

radoering commented Aug 25, 2025 • edited by sourcery-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by Sourcery

Uh oh!

sourcery-ai bot commented Aug 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

Class diagram for updated Provider.use_environment method

File-Level Changes

Possibly linked issues

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Sep 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

radoering commented Aug 25, 2025 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Aug 25, 2025 •

edited

Loading