deps: allow findpython 0.7#10510
Merged
radoering merged 1 commit intopython-poetry:mainfrom Aug 19, 2025
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR relaxes the findpython dependency upper bound to allow 0.7.x releases by updating the version constraint and regenerating the lockfile, and extends the MockPythonVersion test stub with a new freethreaded property. Class diagram for updated MockPythonVersion test stubclassDiagram
class MockPythonVersion {
+major: int
+minor: int
+micro: int
+releaselevel: str
+serial: int
+arch: str
+implementation: str
+path: str
+executable: str
+version: str
+freethreaded: bool
}
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Please regenerate poetry.lock after updating pyproject.toml so that the lock file matches the new findpython constraint.
- Since freethreaded is only introduced in findpython 0.7, add a fallback or guard in the production code to avoid attribute errors when using findpython 0.6.x.
- Consider adding tests that cover both True and False values of the new freethreaded property to validate behavior for different interpreter threading models.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Please regenerate poetry.lock after updating pyproject.toml so that the lock file matches the new findpython constraint.
- Since freethreaded is only introduced in findpython 0.7, add a fallback or guard in the production code to avoid attribute errors when using findpython 0.6.x.
- Consider adding tests that cover both True and False values of the new freethreaded property to validate behavior for different interpreter threading models.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Relax findpython dependency to include version 0.7 and update tests to satisfy its new interface
Enhancements:
Tests: