Bump dulwich to 0.24.0 and update deprecated API usage#10492
Merged
radoering merged 2 commits intopython-poetry:mainfrom Aug 16, 2025
Merged
Bump dulwich to 0.24.0 and update deprecated API usage#10492radoering merged 2 commits intopython-poetry:mainfrom
radoering merged 2 commits intopython-poetry:mainfrom
Conversation
Reviewer's GuideThis PR upgrades the dulwich dependency to the 0.24.x series and replaces all deprecated direct repository operations with the new WorkTree API, ensuring staging, committing, and index resets use repo.get_worktree(). Class diagram for updated Dulwich WorkTree API usageclassDiagram
class Repo {
+get_worktree() WorkTree
}
class WorkTree {
+reset_index()
}
Repo "1" --o "1" WorkTree : get_worktree()
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @jelmer - I've reviewed your changes - here's some feedback:
- Consider extracting get_worktree() into a small helper so you can avoid repeating local.get_worktree() and improve readability.
- Audit the codebase for other dulwich API calls (e.g. repo.stage or repo.do_commit) to ensure all deprecated methods have been updated for v0.24.0.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider extracting get_worktree() into a small helper so you can avoid repeating local.get_worktree() and improve readability.
- Audit the codebase for other dulwich API calls (e.g. repo.stage or repo.do_commit) to ensure all deprecated methods have been updated for v0.24.0.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
- Update dulwich version constraint from >=0.22.6,<0.23.0 to >=0.24.0,<0.25.0 - Use the new WorkTree API in Dulwich, fixing deprecation warnings
radoering
approved these changes
Aug 16, 2025
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Bump Dulwich dependency and migrate to its new WorkTree API to resolve deprecation warnings
Enhancements:
Build:
Tests: