Skip to content

Comments

chore: update dependencies (especially poetry-core) ...#10374

Merged
radoering merged 1 commit intopython-poetry:mainfrom
radoering:update-poetry-core
May 4, 2025
Merged

chore: update dependencies (especially poetry-core) ...#10374
radoering merged 1 commit intopython-poetry:mainfrom
radoering:update-poetry-core

Conversation

@radoering
Copy link
Member

@radoering radoering commented May 4, 2025 •
edited
Loading

... and set upper bound for importlib-metadata, which is only required for Python 3.9

Summary by Sourcery

Chores:

  • Upgrade poetry-core from version 2.1.2 to 2.1.3

@sourcery-ai
Copy link

sourcery-ai bot commented May 4, 2025 •
edited
Loading

Reviewer's Guide

The poetry-core dependency version was updated in pyproject.toml, and the poetry.lock file was regenerated to reflect this change.

File-Level Changes

Change Details Files
Updated the poetry-core dependency version constraint.
  • Changed the version specifier for poetry-core from ==2.1.2 to ==2.1.3.
 pyproject.toml
Updated the lock file to reflect the dependency changes.
  • Regenerated poetry.lock to match the updated dependency specifications in pyproject.toml.
 poetry.lock
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed May 4, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @radoering - I've reviewed your changes - here's some feedback:

  • Consider adding a brief description, perhaps linking to the poetry-core changelog or explaining the reason for the update.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@radoering
chore: update dependencies (especially poetry-core) and set upper bou…
78779f7 
…nd for importlib-metadata, which is only required for Python 3.9
@radoering radoering force-pushed the update-poetry-core branch from b254bcf to 78779f7 Compare May 4, 2025 12:57
@radoering radoering changed the title chore: update dependencies (especially poetry-core) chore: update dependencies (especially poetry-core) ... May 4, 2025
@radoering radoering merged commit aa08f25 into python-poetry:main May 4, 2025
53 checks passed
@radoering radoering mentioned this pull request May 4, 2025
Merged
@learnwithsomya
Copy link

learnwithsomya commented May 29, 2025

Hi @radoering
Can you explain why and where does the changes breaks because of which you need to set a upper-bound for importlib_metadata for Python3.9 ?

@radoering
Copy link
Member Author

radoering commented May 29, 2025

@somyarj1637 Just take a look at the changes. There is a comment:

    # <8.7 because .metadata() (and Distribution.metadata) can now return None,
    # which requires some adaptions to our code.

Further, it is only Python 3.9 because we do not need importlib-metadata for later Python versions.

@github-actions
Copy link

github-actions bot commented Jun 29, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2025
@radoering radoering deleted the update-poetry-core branch December 13, 2025 17:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@Secrus Secrus Secrus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@radoering @learnwithsomya @Secrus