Skip to content

Comments

Rename ruff ruleset: TCH → TC#10373

Merged
radoering merged 1 commit intopython-poetry:mainfrom
DimitriPapadopoulos:TCH
May 4, 2025
Merged

Rename ruff ruleset: TCH → TC#10373
radoering merged 1 commit intopython-poetry:mainfrom
DimitriPapadopoulos:TCH

Conversation

@DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented May 4, 2025 •
edited by sourcery-ai bot
Loading

Ruff 0.8.0 changes the error codes for the rules in the flake8-type-checking category from TCH to TC. This matches changes that were made in the original flake8-type-checking plugin from which these rules were originally adapted.

https://astral.sh/blog/ruff-v0.8.0#new-error-codes-for-flake8-type-checking-rules

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

Summary by Sourcery

Chores:

  • Update Ruff configuration to use new error code prefix for type-checking rules

@sourcery-ai
Copy link

sourcery-ai bot commented May 4, 2025 •
edited
Loading

Reviewer's Guide

This PR updates the pyproject.toml file to replace the ruff ruleset code TCH with TC, aligning with ruff v0.8.0.

File-Level Changes

Change Details Files
Updated ruff ruleset code from TCH to TC in configuration.
  • Replaced TCH with TC in the extend-select list.
  • Replaced TCH with TC in the extend-safe-fixes list.
 pyproject.toml
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@DimitriPapadopoulos @radoering
Rename ruff ruleset: TCH → TC
f38da3a 
Ruff 0.8.0 changes the error codes for the rules in the flake8-type-checking
category from TCH to TC. This matches changes that were made in the original
flake8-type-checking plugin from which these rules were originally adapted.

https://astral.sh/blog/ruff-v0.8.0#new-error-codes-for-flake8-type-checking-rules
@radoering radoering enabled auto-merge (squash) May 4, 2025 11:59
@radoering radoering merged commit b0a982e into python-poetry:main May 4, 2025
53 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the TCH branch May 4, 2025 12:18
@github-actions
Copy link

github-actions bot commented Jun 4, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radoering radoering radoering approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DimitriPapadopoulos @radoering