Skip to content

Comments

add useful information to error message#10367

Merged
radoering merged 1 commit intopython-poetry:mainfrom
radoering:improve-error-message
May 4, 2025
Merged

add useful information to error message#10367
radoering merged 1 commit intopython-poetry:mainfrom
radoering:improve-error-message

Conversation

@radoering
Copy link
Member

@radoering radoering commented May 1, 2025

Summary by Sourcery

Bug Fixes:

  • Enhanced error message to provide more context when package creation fails due to missing name

@sourcery-ai
Copy link

sourcery-ai bot commented May 1, 2025

Reviewer's Guide

This pull request enhances an error message by adding the relevant directory path (root_dir) to the RuntimeError raised when a package name is missing during package creation.

File-Level Changes

Change Details Files
Enhanced error message context.
  • Included root_dir in the RuntimeError message when package name is missing in to_package function.
src/poetry/inspection/info.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @radoering - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@radoering radoering force-pushed the improve-error-message branch from 839a316 to 616b507 Compare May 4, 2025 12:06
@radoering radoering merged commit 865e928 into python-poetry:main May 4, 2025
53 checks passed
@github-actions
Copy link

github-actions bot commented Jun 4, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2025
@radoering radoering deleted the improve-error-message branch December 13, 2025 17:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant