Skip to content

Comments

tests: fix expectation for FreeBSD#10350

Merged
radoering merged 1 commit intopython-poetry:mainfrom
radoering:fix-freebsd-tests
Apr 20, 2025
Merged

tests: fix expectation for FreeBSD#10350
radoering merged 1 commit intopython-poetry:mainfrom
radoering:fix-freebsd-tests

Conversation

@radoering
Copy link
Member

@radoering radoering commented Apr 19, 2025 •
edited by sourcery-ai bot
Loading

It looks like the workaround is not necessary anymore with recent versions.

Summary by Sourcery

Tests:

  • Remove a conditional package expectation for FreeBSD that is no longer necessary

@radoering
tests: fix expectation for FreeBSD
86898cb 
It looks like the workaround is not necessary anymore with recent versions.
@sourcery-ai
Copy link

sourcery-ai bot commented Apr 19, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request removes a workaround for FreeBSD in the test suite. The workaround was previously added to account for the presence of the sqlite3 package in the system site packages on FreeBSD systems when the with_system_site_packages flag is not set. Recent versions of FreeBSD no longer require this workaround, so it has been removed to simplify the test and avoid unnecessary conditional logic.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Removed FreeBSD-specific workaround in test_system_site_packages test.
  • Removed conditional logic that added sqlite3 to the expected packages on FreeBSD when with_system_site_packages is false.
 tests/repositories/test_installed_repository.py
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Apr 19, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @radoering - I've reviewed your changes - here's some feedback:

Overall Comments:

  • It would be useful to add a comment explaining why the workaround is no longer necessary.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@radoering radoering requested a review from a team April 19, 2025 17:32
@radoering radoering merged commit 5129ce4 into python-poetry:main Apr 20, 2025
53 checks passed
@github-actions
Copy link

github-actions bot commented May 21, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2025
@radoering radoering deleted the fix-freebsd-tests branch December 13, 2025 17:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@radoering