fix: installer.no-binary/installer.only-binary :all: to lower priority by yokomotod · Pull Request #10278 · python-poetry/poetry

yokomotod · 2025-03-15T19:52:49Z

Pull Request Check List

Resolves: #10231

Added tests for changed code.
Updated documentation for changed code.

Summary by Sourcery

Tests:

Adds tests to verify that installer.no-binary takes precedence over installer.only-binary when both are specified for a package.

sourcery-ai · 2025-03-15T19:52:52Z

Reviewer's Guide by Sourcery

This pull request fixes an issue where the installer.only-binary configuration was taking precedence over the installer.no-binary configuration. The changes ensure that installer.no-binary always takes precedence when both configurations match a package. This was achieved by modifying the distribution selection logic and adding new test cases.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Ensured that the `installer.no-binary` configuration takes precedence over the `installer.only-binary` configuration when both match a package.	Modified the logic in `choose_for` to prioritize `no_binary` over `only_binary` when selecting a distribution. Added test cases to verify the precedence of `no_binary` over `only_binary` in the `test_chooser_only_binary_policy` test. Updated documentation to reflect the precedence of `installer.no-binary` over `installer.only-binary`.	`src/poetry/installation/chooser.py` `tests/installation/test_chooser.py` `docs/configuration.md`

Possibly linked issues

Poetry V2: Change ONLY_BINARY/NO_BINARY implementation so that you can ONLY_BINARY=:all: NO_BINARY=one_package #10231: The PR implements the functionality requested in the issue.

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!
Generate a plan of action for an issue: Comment @sourcery-ai plan on
an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai

Hey @yokomotod - I've reviewed your changes - here's some feedback:

Overall Comments:

The added test cases cover the intended behavior well.

Here's what I looked at during the review

🟢 General issues: all looks good
🟢 Security: all looks good
🟢 Testing: all looks good
🟢 Complexity: all looks good
🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

dimbleby · 2025-03-15T20:15:50Z

And what if someone wants NO_BINARY=:all: ONLY_BINARY=some_package? Why is the proposed order of precedence better?

src/poetry/installation/chooser.py

yokomotod · 2025-03-15T20:33:41Z

And what if someone wants NO_BINARY=:all: ONLY_BINARY=some_package? Why is the proposed order of precedence better?

pip seems to have same precedence

$ pip install --dry-run --no-cache-dir --only-binary=requests --no-binary=:all: requests
Collecting requests
  Downloading requests-2.32.3.tar.gz (131 kB)

.......

Would install requests-2.32.3

dimbleby · 2025-03-15T20:41:23Z

pip seems to have same precedence

poetry is not pip, pip is not a standard. Perhaps if you reported that example to pip, they'd treat it as a bug.

The question is: why is the proposed precedence better?

yokomotod · 2025-03-15T21:22:16Z

I see.

The reason for this precedence is to achieve ONLY_BINARY=:all: NO_BINARY=some_package as described in #10231. We can use NO_BINARY as an exclusion of ONLY_BINARY=:all:.
I'm not sure of the motivation or use case of NO_BINARY=:all: ONLY_BINARY=some_package.
So, I think this precedence is more useful and better.

On the other hand, I agree that it's a bit weird that ONLY_BINARY=some_package NO_BINARY=some_package results in NO_BINARY=some_package.

If we don't care about pip, I think another option is to "lower the priority of :all:".
Then both ONLY_BINARY=:all: NO_BINARY=some_package and NO_BINARY=:all: ONLY_BINARY=some_package can work as exclusions, and obviously conflicted options like ONLY_BINARY=some_package NO_BINARY=some_package, ONLY_BINARY=:all: NO_BINARY=:all: keep the current behavior (failed to install).

What do you think?

dimbleby · 2025-03-15T21:50:29Z

That sounds preferable to me, I would expect the treatment to be as near as possible symmetrical.

But I will say that this is not a feature I expect ever to use, so I am not personally especially invested either way

yokomotod · 2025-03-15T23:57:07Z

@dimbleby changed to lower :all: precedence

src/poetry/installation/chooser.py

github-actions · 2025-03-23T16:35:36Z

Deploy preview for website ready!

✅ Preview
https://website-i6gqktb57-python-poetry.vercel.app

Built with commit 16bd8b3.
This pull request is being automatically deployed with vercel-action

docs/configuration.md

github-actions · 2025-09-09T00:32:18Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

sourcery-ai bot reviewed Mar 15, 2025

View reviewed changes

dimbleby reviewed Mar 15, 2025

View reviewed changes

src/poetry/installation/chooser.py Outdated Show resolved Hide resolved

yokomotod changed the title ~~fix: installer.no-binary takes precedence over installer.only-binary~~ fix: installer.no-binary/installer.only-binary :all: to lower priority Mar 15, 2025

yokomotod force-pushed the no-binary-and-only-binary branch 2 times, most recently from d0682cb to 663c64d Compare March 15, 2025 23:41

dimbleby reviewed Mar 16, 2025

View reviewed changes

src/poetry/installation/chooser.py Show resolved Hide resolved

radoering force-pushed the no-binary-and-only-binary branch from 82792e6 to 228d865 Compare March 23, 2025 16:34

radoering added the impact/docs Contains or requires documentation changes label Mar 23, 2025

radoering reviewed Mar 23, 2025

View reviewed changes

docs/configuration.md Outdated Show resolved Hide resolved

radoering reviewed Aug 9, 2025

View reviewed changes

docs/configuration.md Outdated Show resolved Hide resolved

yokomotod and others added 6 commits August 9, 2025 15:19

fix: installer.no-binary takes precedence over installer.only-binary

cecbc61

sort test parameters

0ee8993

fix doc

b9f8f4e

change to :all: has lower priority

56eb2bf

fix readability

8ab824c

remove redundant sentence

16bd8b3

radoering force-pushed the no-binary-and-only-binary branch from 05956d1 to 16bd8b3 Compare August 9, 2025 13:19

radoering approved these changes Aug 9, 2025

View reviewed changes

radoering merged commit fee7d0d into python-poetry:main Aug 9, 2025
54 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2025

Comments

Conversation

yokomotod commented Mar 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Check List

Summary by Sourcery

Uh oh!

sourcery-ai bot commented Mar 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide by Sourcery

File-Level Changes

Possibly linked issues

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

dimbleby commented Mar 15, 2025

Uh oh!

Uh oh!

yokomotod commented Mar 15, 2025

Uh oh!

dimbleby commented Mar 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yokomotod commented Mar 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dimbleby commented Mar 15, 2025

Uh oh!

yokomotod commented Mar 15, 2025

Uh oh!

Uh oh!

github-actions bot commented Mar 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Sep 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yokomotod commented Mar 15, 2025 •

edited

Loading

sourcery-ai bot commented Mar 15, 2025 •

edited

Loading

dimbleby commented Mar 15, 2025 •

edited

Loading

yokomotod commented Mar 15, 2025 •

edited

Loading

github-actions bot commented Mar 23, 2025 •

edited

Loading