Skip to content

Comments

fix(env): use csh activation script for tcsh#10243

Merged
radoering merged 1 commit intopython-poetry:mainfrom
vedranmiletic:main
Mar 4, 2025
Merged

fix(env): use csh activation script for tcsh#10243
radoering merged 1 commit intopython-poetry:mainfrom
vedranmiletic:main

Conversation

@vedranmiletic
Copy link
Contributor

@vedranmiletic vedranmiletic commented Mar 3, 2025 •
edited by sourcery-ai bot
Loading

Pull Request Check List

Resolves: virtualenv activation currently uses Bash script when shell is tcsh, which doesn't work, so this change makes it use the csh activation script

  • Added tests for changed code.
  • Updated documentation for changed code.

Summary by Sourcery

Bug Fixes:

  • Fixes virtualenv activation to use the csh activation script when the shell is tcsh.

@sourcery-ai
Copy link

sourcery-ai bot commented Mar 3, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request modifies the activate command to use the csh activation script for tcsh shells, which were previously incorrectly using the bash script. A test case has been added to verify the correct behavior.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Modified the activate command to use the csh activation script for both csh and tcsh shells.
  • Updated the _get_activate_command method to include tcsh when selecting the csh activation script.
  • Added a test case for the tcsh shell to ensure the correct activation script is used.
 src/poetry/console/commands/env/activate.py
tests/console/commands/env/test_activate.py
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Mar 3, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @vedranmiletic - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a comment explaining why tcsh is being added to the csh case.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@radoering radoering merged commit ce90ffb into python-poetry:main Mar 4, 2025
53 checks passed
@radoering radoering mentioned this pull request Mar 29, 2025
Merged
@github-actions
Copy link

github-actions bot commented Apr 4, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@radoering radoering radoering approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vedranmiletic @radoering