fix(puzzle): handle self-referential extras#10124
Closed
abn wants to merge 1 commit intopython-poetry:mainfrom
Closed
fix(puzzle): handle self-referential extras#10124abn wants to merge 1 commit intopython-poetry:mainfrom
abn wants to merge 1 commit intopython-poetry:mainfrom
Conversation
Reviewer's Guide by SourceryThis pull request introduces the ability to handle self-referential extras in package dependencies. It modifies the solver to correctly resolve dependencies when extras refer to each other, either directly or through nested extras. Additionally, it includes new test cases to verify the correct behavior of the solver and installer with self-referential extras. Class diagram for dependency resolution changesclassDiagram
class Package {
+extras: Dict
+requires: List
+is_root(): bool
}
class Dependency {
+name: str
+extras: Set
+is_optional(): bool
+in_extras: List
}
class Provider {
+complete_package()
}
Package -- Dependency : contains
Provider -- Package : processes
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
|
I'm not sure what you're trying to do in the failing test, so far as I can tell the code is right and the test is wrong. I think the sort of test you want is something like:
|
Member
Author
You are quite possibly correct. I only looked at it briefly, and the test setup is incorrect. That said, there is also the issue of the marker not being propagated or being accounted for if it is on an extra dependency; which I had hoped #10119 would fix - but I reckon that was incomplete as well. |
Co-authored-by: David Hotham <[email protected]>
abn
force-pushed
the
fix/install-with-extra-hotham
branch
from
973c8f4 to
e251296
Compare
Member
Author
|
Sorry about the multiple threads, decided to go back to #10106 to keep things together. #10106 (comment) |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative proposed by @dimbleby for #10106.
Raising this as a draft to preserve the proposed chang as I had to revert to my original approach to ensure tests passed once #10119 was merged to
main.Summary by Sourcery
Tests: