Reviewer's Guide by Sourcery

This pull request modifies how Poetry invokes pip commands, preferring the embedded pip wheel over the in-environment version, except when the user explicitly uses poetry run pip. This change aims to avoid potential issues caused by using the in-environment pip version.

Sequence diagram for Poetry's pip command execution flow

sequenceDiagram
    participant Poetry
    participant BaseEnv
    participant PipCommand

alt prefer_in_env=True and pip exists in environment
    Poetry->>BaseEnv: get_pip_command(prefer_in_env=true)
    BaseEnv->>PipCommand: Execute [python, -m, pip]
else Default case or pip not in environment
    Poetry->>BaseEnv: get_pip_command(prefer_in_env=false)
    BaseEnv->>PipCommand: Execute [python, embedded_pip]
end

Flow diagram for pip command selection logic

flowchart TD
    A[Start] --> B{prefer_in_env?}
    B -->|Yes| C{Pip exists in env?}
    C -->|Yes| D[Use in-env pip]
    C -->|No| E[Use embedded pip]
    B -->|No| E
    D --> F[Execute pip command]
    E --> F
    F --> G[End]

File-Level Changes

cf #6060, #6062

really what we want is to stop using pip altogether, iirc the remaining cases are:

• uninstall
• certain cases where the local project has a build step

uninstall is clearly the more important, there is discussion in #9263

Ah #6060 and #6062 were what I was missing.

I agree that we should really just drop the uninstall case. The build step is already using an isolated builder now in main.

I'll see if I can implement some uninstaller based on pip's logic as a starter. If it's easy enough we can avoid reverting part of #9392.

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.