Skip to content

Comments

tests: adapt tests to cosmetic changes caused by poetry-core#818#10073

Merged
abn merged 1 commit intopython-poetry:mainfrom
radoering:perf-atomic-extra
Jan 18, 2025
Merged

tests: adapt tests to cosmetic changes caused by poetry-core#818#10073
abn merged 1 commit intopython-poetry:mainfrom
radoering:perf-atomic-extra

Conversation

@radoering
Copy link
Member

@radoering radoering commented Jan 18, 2025 •
edited by sourcery-ai bot
Loading

Pull Request Check List

see issue title

  • Added tests for changed code.
  • Updated documentation for changed code.

Summary by Sourcery

Tests:

  • Adapt tests to handle marker formatting changes.

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 18, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request adapts tests to cosmetic changes caused by poetry-core#818. The changes involve reordering the conditions in the markers to match the new output from poetry-core.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Reordered conditions in the markers to match the new output from poetry-core.
  • Reordered conditions in complex marker strings in test_solver_duplicate_dependencies_with_overlapping_markers_complex.
  • Reordered conditions in marker strings in test_propagate_markers_with_root_extra.
 tests/puzzle/test_solver.py
tests/puzzle/test_solver_internals.py
Updated the poetry-core dependency to a specific commit.
  • Updated the poetry-core dependency to a specific commit on the perf-atomic-extra branch.
 pyproject.toml
Updated lock file and test fixtures.
  • Updated the lock file to reflect the changes in pyproject.toml.
  • Updated test fixtures to reflect the changes in the lock file.
 poetry.lock
tests/installation/fixtures/with-conflicting-dependency-extras-transitive.test
tests/installation/fixtures/with-dependencies-differing-extras.test
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Jan 18, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @radoering - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Using a git dependency for poetry-core could lead to instability. Consider waiting for an official release that includes these changes instead.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@radoering radoering mentioned this pull request Jan 18, 2025
Merged
2 tasks
@radoering radoering requested a review from a team January 18, 2025 15:39
@abn abn enabled auto-merge (rebase) January 18, 2025 15:53
@abn abn merged commit 77cd259 into python-poetry:main Jan 18, 2025
73 checks passed
@github-actions
Copy link

github-actions bot commented Feb 18, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2025
@radoering radoering deleted the perf-atomic-extra branch December 13, 2025 17:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@abn abn abn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@radoering @abn