Skip to content

Replace poetry lock --check with poetry check --lock #6756

@johnthagen

Description

@johnthagen
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have searched the FAQ and general documentation and believe that my question is not already covered.

Feature Request

There is an important need for development teams to validate their Poetry configuration files and lockfile freshness in CI. This should ideally be done in a single, easy to understand command.

The following PR added poetry lock --check:

The problem is that this is a somewhat strange UI, especially given that the separate poetry check command already exists (and existed). Sebastian noted this and asked for a revert (which must never have happened?):

I propose, similar to Sebastian, that poetry lock --check be deprecated and its functionality moved to poetry check --lock. This would be easier to teach and explain to new Poetry users and would keep all "file validation logic" under poetry check.

poetry check --lock would therefor be the superset of everything that is checked in poetry check and poetry lock --check so that a user can run a single command in CI and get all validation performed.

@neersighted seemed to agree in:

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/cliRelated to the command linearea/uxFeatures and improvements related to the user experienceimpact/deprecationIntroduces or relates to a deprecationstatus/acceptedFeature request accepted for the roadmap

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions