Skip to content

Poetry is not using Dulwich to read the global git config (particularly the insteadOf option) #5934

@fredrikaverpil

Description

@fredrikaverpil
  • I am on the latest Poetry version (master branch)
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).
  • OS version and name: GitHub Actions
  • Poetry version: master branch

Issue

⚠️ please note that this functionality works fine with Poetry 1.1.13 but is now unsupported in the pre-1.2 master branch (unless configuring poetry@master to use the system's git client).

It doesn't seem like poetry is using Dulwich to read the global git config. Should it not do this?
I'm using Poetry in GitHub Actions with private repos and would like to rely on rewriting URLs with insteadOf:

git config --global --replace-all url.https://github.com/.insteadOf ssh://[email protected]/
git config --global --add url.https://github.com/.insteadOf [email protected]:

Dulwich recently added support for rewriting URLs 🎉 (PR here) this - but this is not picked up by poetry.

I initially raised this with the Dulwich maintainers in jelmer/dulwich#983 but they concluded the issue seems to reside with Poetry.

What is the intent here...?

  • Should Poetry use Dulwich to read the global (and the repo's?) git config?
  • What is the way forward to make Poetry read the global git config, and the insteadOf option in particular?

Cc @neersighted (as we chatted briefly about this in discord)

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugSomething isn't working as expected

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions