Skip to content

poetry shell not use nushell when spawning shell for virtual environment #5349

@gunungpw

Description

@gunungpw
  • I am on the latest Poetry version.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).
  • OS version and name: Windows 10
  • Poetry version: 1.1.13
  • Link of a Gist with the contents of your pyproject.toml file:
[tool.poetry]
name = "demo-shellingham"
version = "0.1.0"
description = ""
authors = ["Gunung Pambudi W. <[email protected]>"]

[tool.poetry.dependencies]
python = "^3.10"
shellingham = "^1.4.0"

[tool.poetry.dev-dependencies]
pytest = "^5.2"

[build-system]
requires = ["poetry-core>=1.0.0"]
build-backend = "poetry.core.masonry.api"

Issue

Poetry shell command doesn't spawn virtual environment with intended shell. In this case poetry not use Nushell. This problem is caused by shellingham dependency not detect nushell in this case nu.exe but detect other shell like pwsh.exe or cmd.exe following COMSPEC env variable in Windows.
I make PR in shellingham to include nushell

sarugaku/shellingham#56

edit: PR already merge

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugSomething isn't working as expected

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions