Skip to content

Missing return for link.is_wheel==True #4966

@Anselmoo

Description

@Anselmoo
  • I am on the latest Poetry version.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • OS version and name: macOS:latest
  • Poetry version: 1.1.12
  • Link of a Gist with the contents of your pyproject.toml file:

Issue

According to PR #4962, there is the question left, if pass should not be replaced by a return. This would be also consistent with the typing definition Optional[Link].

def get_cached_archive_for_link(self, link: Link) -> Optional[Link]:
# If the archive is already a wheel, there is no need to cache it.
if link.is_wheel:
pass

At the moment

archives = self.get_cached_archives_for_link(link)

will be always excetuded.

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugSomething isn't working as expected

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions