-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Closed
Labels
area/installerRelated to the dependency installerRelated to the dependency installerkind/enhancementNot a bug or feature, but improves usability or performanceNot a bug or feature, but improves usability or performance
Description
Today, the editable installer (poetry>1.0.10), does not handle removals of files (includes, console scripts etc.) cleanly. This needs to be improved.
There are two potential approaches,
- Handle the delta manually by using the
*.dist-info/RECORDcsv file. We could load the list prior to new install and then identify the delta after installation. - Uninstall editable package explicitly (this today might need to use pip until poetry has an internal mechanism) prior to installation again. This might be cleaner as this should separate the concerns cleanly.
Reproduction
This issue can be reproduced as follows.
poetry new foo
pushd foo
sed -i /pytest/d pyproject.toml
echo 'def main(): print("hello world")' >> foo/__init__.py
printf '\n\n[tool.poetry.scripts]\nhello = "foo:main"' >> pyproject.toml
poetry install
sed -i s/hello/world/g pyproject.toml
poetry installToday, once this is done, the following happens.
$ poetry run type hello
hello is /tmp/foo/.venv/bin/helloWe expect this to happen.
$ poetry run type hello
/usr/bin/type: line 2: type: hello: not foundReactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area/installerRelated to the dependency installerRelated to the dependency installerkind/enhancementNot a bug or feature, but improves usability or performanceNot a bug or feature, but improves usability or performance