-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Closed
Labels
kind/enhancementNot a bug or feature, but improves usability or performanceNot a bug or feature, but improves usability or performance
Description
- I am on the latest Poetry version.
- I have searched the issues of this repo and believe that this is not a duplicate.
- If an exception occurs when executing a command, I executed it again in debug mode (
-vvvoption).
- OS version and name: macOS 10.14.6
- Poetry version: 1.0.5
- Link of a Gist with the contents of your pyproject.toml file: https://gist.github.com/bb/501f33ad3f35eb8c26ce2513ca6074c8
Issue
When adding a new dependency, it is downloaded multiple times; I observed three downloads, two of those are unneccessary.
Starting with a pyproject.toml as in the Gist given above, I run
poetry add https://github.com/oroszgy/spacy-hungarian-models/releases/download/hu_core_ud_lg-0.3.1/hu_core_ud_lg-0.3.1-py3-none-any.whl
Then I see the following output (XXX added as markers for explanation below):
Updating dependencies XXX
Resolving dependencies... (276.1s)
Writing lock file
XXX
Package operations: 0 installs, 7 updates, 0 removals
- Updating certifi (2019.11.28 -> 2020.4.5.1)
- Updating urllib3 (1.25.8 -> 1.25.9)
- Updating asgiref (3.2.3 -> 3.2.7)
- Updating pytz (2019.3 -> 2020.1)
- Updating django (3.0.4 -> 3.0.6)
- Updating hu-core-ud-lg (0.3.1 -> 0.3.1 https://github.com/oroszgy/spacy-hungarian-models/releases/download/hu_core_ud_lg-0.3.1/hu_core_ud_lg-0.3.1-py3-none-any.whl)
XXX - Updating psycopg2-binary (2.8.4 -> 2.8.5)
At the positions where the marker XXX is inserted, the same 1.3GB download is done again and again.
Similar, when adding another package later, again XXX marks the cursor position when the big download is done:
$ poetry add djangorestframework
Using version ^3.11.0 for djangorestframework
Updating dependencies
Resolving dependencies... (0.4s)
Writing lock file
XXX
Package operations: 1 install, 1 update, 0 removals
- Installing djangorestframework (3.11.0)
- Updating hu-core-ud-lg (0.3.1 -> 0.3.1 https://github.com/oroszgy/spacy-hungarian-models/releases/download/hu_core_ud_lg-0.3.1/hu_core_ud_lg-0.3.1-py3-none-any.whl)
XXX
I'd expect the file to be downloaded a most once and reused.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
kind/enhancementNot a bug or feature, but improves usability or performanceNot a bug or feature, but improves usability or performance