Fix permission errors when adding/removing git dependencies on Windows

sdispater · shawegit · sdispater · commit c12d86b79e16 · 2018-11-09T15:35:28.000-05:00
Co-authored-by: shawegit &lt;shawegit@users.noreply.github.com&gt;
Co-authored-by: Sébastien Eustace &lt;sebastien@eustace.io&gt;
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,12 @@
 # Change Log
 
+## [Unreleased]
+
+### Fixed
+
+- Fixed permission errors when adding/removing git dependencies on Windows.
+
+
 ## [0.12.7] - 2018-11-08
 
 ### Fixed
diff --git a/poetry/installation/pip_installer.py b/poetry/installation/pip_installer.py
@@ -6,6 +6,7 @@
 
 from poetry.config import Config
 from poetry.utils.helpers import get_http_basic_auth
+from poetry.utils.helpers import safe_rmtree
 
 
 try:
@@ -97,7 +98,7 @@ def remove(self, package):
         if package.source_type == "git":
             src_dir = self._env.path / "src" / package.name
             if src_dir.exists():
-                shutil.rmtree(str(src_dir))
+                safe_rmtree(str(src_dir))
 
         try:
             self.run("uninstall", package.name, "-y")
@@ -208,7 +209,7 @@ def install_git(self, package):
 
         src_dir = self._env.path / "src" / package.name
         if src_dir.exists():
-            shutil.rmtree(str(src_dir))
+            safe_rmtree(str(src_dir))
 
         src_dir.parent.mkdir(exist_ok=True)
 
diff --git a/poetry/puzzle/provider.py b/poetry/puzzle/provider.py
@@ -32,7 +32,7 @@
 from poetry.utils._compat import PY35
 from poetry.utils._compat import Path
 from poetry.utils.helpers import parse_requires
-from poetry.utils.toml_file import TomlFile
+from poetry.utils.helpers import safe_rmtree
 from poetry.utils.env import Env
 from poetry.utils.env import EnvCommandError
 from poetry.utils.setup_reader import SetupReader
@@ -196,7 +196,7 @@ def search_for_vcs(self, dependency):  # type: (VCSDependency) -> List[Package]
         except Exception:
             raise
         finally:
-            shutil.rmtree(tmp_dir.as_posix())
+            safe_rmtree(str(tmp_dir))
 
         return [package]
 
diff --git a/poetry/utils/helpers.py b/poetry/utils/helpers.py
@@ -1,5 +1,7 @@
+import os
 import re
 import shutil
+import stat
 import tempfile
 
 from contextlib import contextmanager
@@ -89,3 +91,12 @@ def get_http_basic_auth(
         return repo_auth["username"], repo_auth.get("password")
 
     return None
+
+
+def _on_rm_error(func, path, exc_info):
+    os.chmod(path, stat.S_IWRITE)
+    func(path)
+
+
+def safe_rmtree(path):
+    shutil.rmtree(path, onerror=_on_rm_error)
