refactor(parser): delete doc-based command configuration parser#239
Merged
branchv merged 6 commits intopython-poetry:mainfrom Sep 5, 2022
Merged
refactor(parser): delete doc-based command configuration parser#239branchv merged 6 commits intopython-poetry:mainfrom
branchv merged 6 commits intopython-poetry:mainfrom
Conversation
branchv
requested changes
Sep 1, 2022
Member
branchv
left a comment
branchv
left a comment
There was a problem hiding this comment.
Couple tweaks. Also let's update the snippets in the README + add a line in the CHANGELOG
Co-authored-by: Branch Vincent <[email protected]>
branchv
approved these changes
Sep 5, 2022
|
Are there any documented steps for migration from doc-based configs to the new method? Or do we have do it manually? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With sdispaters blessing, I removed the option to configure commands via the
__doc__comment. It was adding too much unnecessary complexity to code and was prone to bugs (like all custom grammar parsers).Resolves: #65
Resolves: #64
Resolves: #55