Skip to content

Comments

Fix CI | Update black version in pre-commit#137

Merged
branchv merged 5 commits intopython-poetry:masterfrom
Bobronium:patch-1
May 27, 2022
Merged

Fix CI | Update black version in pre-commit#137
branchv merged 5 commits intopython-poetry:masterfrom
Bobronium:patch-1

Conversation

@Bobronium
Copy link
Contributor

@Bobronium Bobronium commented May 22, 2022

This fixes CI failure caused by pallets/click#2225

@Bobronium Bobronium changed the title Update black version in pre-commit Fix CI | Update black version in pre-commit May 22, 2022
@Bobronium Bobronium mentioned this pull request May 22, 2022
Merged
branchv
branchv requested changes May 27, 2022
View reviewed changes
Copy link
Member

@branchv branchv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Bobronium, do you mind pushing black's changes as well so checks can pass?

Bobronium added 2 commits May 27, 2022 23:42
@Bobronium
Update black and python version
2fba546 
Python version is updated to satisfy black constraint

The current project's Python requirement (>=3.6,<4.0) is not compatible with some of the required packages Python requirement:
    - black requires Python >=3.6.2, so it will not be satisfied for Python >=3.6,<3.6.2
@Bobronium
Reformat files with black 22.3.0
2d0064b
@Bobronium
Copy link
Contributor Author

Bobronium commented May 27, 2022

@branchvincent, done!

Had to update python minor version as well.

@Bobronium
Copy link
Contributor Author

Bobronium commented May 27, 2022 •
edited
Loading

I guess CI hasn't been working for a while. poetry installation fails, as well as python 3.6 on macOS.

Can say right away that poetry installed witth legacy install-poetry script, as for python — I have no idea :)

Turns out, I confused install-poetry.py with get-poetry.py

branchv
branchv reviewed May 27, 2022
View reviewed changes
@branchv
Copy link
Member

branchv commented May 27, 2022

tests fail since the latest pre-release of poetry dropped 3.6 support, we could pin to --version=1.2.0a2 but even that just uncovers more issues with 3.6 support: https://github.com/branchvincent/cleo/runs/6631287709?check_suite_focus=true

I can handle those issues in another PR, getting linting to pass here is more than sufficient

branchv
branchv approved these changes May 27, 2022
View reviewed changes
Copy link
Member

@branchv branchv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot!

@branchv branchv merged commit e103e1c into python-poetry:master May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@branchv branchv branchv approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Bobronium @branchv