Decrease default errors verbosity#132
Conversation
|
@sdispater, please take a look when you'll have time |
|
What's the reasoning behind making the stack trace available only for the very verbose verbosity onwards? I would prefer to keep it at the verbose level. Otherwise the rest looks good. |
|
@sdispater, if it would be displayed on verbose, then there wouldn't be an option to show compact source reference anymore. In current implementation, verbosity will gradually increase:
If full stack trace is shown on
I wouldn't want to loose such feature since it's sufficient in most cases, and when more needed — one can ask for more by |
|
Thanks for the explanation, I somehow missed this subtlety. Works for me then 👍 |
|
Seems like failed with pallets/click#2225, |
|
Is there anything preventing merging/releasing this? |
|
@Bobronium could you please fix pre-commit issues and rebase with current master? |
|
@Bobronium do you mind rebasing this? We'll be releasing a new version soon and it would be great to include this |
|
@branchvincent, no, I don't mind. I might get to this today or tomorrow. |
09cb481 to
8c763f8
Compare
Remove Inspector import Reformat cleo/ui/exception_trace.py with black
|
@Secrus, @branchvincent, done! |
This shifts error verbosity to reduce terminal output pollution
Replaces
python-poetry/poetry#2915
python-poetry/poetry#5559
Resolves:
python-poetry/poetry#2854
python-poetry/poetry#3273
python-poetry/poetry#4014
python-poetry/poetry#5229
Current behaviour
CleoSimpleException: render it with just a message, never display solutionio.is_verbose(): default + full stack traceNew behaviour
CleoSimpleException: render error with just a message + solution if presentio.is_verbose(): render error with source reference + solution if presentio.is_very_verbose():io.is_verbose()+ full stack traceIn other words
simpleis enabled by default (whilst supporting solutions)verboseis now previous default (compact source reference)very_verboseis now previousverboseShowcase