address type errors in 'cleo._utils'#122
Conversation
danieleades
force-pushed
the
typing/cleo._utils
branch
from
39a1ca5 to
92263bd
Compare
|
@branchvincent this is rebased and ready for review |
danieleades
force-pushed
the
typing/cleo._utils
branch
3 times, most recently
from
7b633ad to
84ff5fb
Compare
danieleades
force-pushed
the
typing/cleo._utils
branch
from
84ff5fb to
1a05071
Compare
tests/test_utils.py
Outdated
| (0.1, "< 1 sec"), | ||
| (1.0, "1 sec"), | ||
| (2.0, "2 secs"), | ||
| (59.0, "59 secs"), | ||
| (60.0, "1 min"), | ||
| (120.0, "2 mins"), |
There was a problem hiding this comment.
@branchvincent do these test cases match your expectations? (this is failing, currently)
There was a problem hiding this comment.
Cool. That means there's a bug with the current implementation.
I'll need to find some time to revisit this. Was a while ago...
There was a problem hiding this comment.
haha of course! take your time, thanks a lot for helping out
|
Any progress on this? Anything you need help with? |
a response to this comment would be handy - #122 (comment) |
Secrus
left a comment
Secrus
left a comment
There was a problem hiding this comment.
You might want to update your code with changes from the master branch since _utils module and its tests changed.
Secrus
force-pushed
the
typing/cleo._utils
branch
from
a2bc51e to
1885fb6
Compare
|
@danieleades hope you don't mind, I took it upon myself and fixed the bug and lingering |
Secrus
dismissed
their stale review
Added code to that, not eligible to review that anymore
no problem here! LGTM |
|
thanks again @danieleades! |
3 participants
this is stacked on #121