This repository was archived by the owner on Oct 8, 2024. It is now read-only.
Merged
Conversation
21 tasks
hugovk
approved these changes
Aug 21, 2023
Member
hugovk
left a comment
hugovk
left a comment
There was a problem hiding this comment.
Sure, let's merge this closer to the release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zlib 1.3 has been released - https://zlib.net/
You will notice that the stable macOS jobs fail. This is because stable does not yet include python-pillow/Pillow#7344. I half expect there to be a preference to delay merging this, to avoid almost 2 months of the wheels main failing until the next Pillow release updates stable.
You might wonder why the stable Linux jobs aren't failing. It is actually only reporting zlib 1.2.11. I have investigated, and can't find any evidence on the filesystem as to why this would be. In the absence of other options, I conclude it is related to https://github.com/pypa/auditwheel/blob/main/src/auditwheel/policy/manylinux-policy.json - in other words, I suspect this is the highest zlib version allowed for these manylinux wheels.