Upload wheels to GitHub Releases by hugovk · Pull Request #156 · python-pillow/pillow-wheels

hugovk · 2020-07-07T15:34:56Z

Fixes #146, using one of @mattip's suggestions.

Based on Cython's config:

https://github.com/MacPython/cython-wheels/blob/b421040fd59ccd1cee9b2cb66b79a3d6bacde444/.travis.yml#L116-L125

Travis CI docs:

https://docs.travis-ci.com/user/deployment/releases/

The wheels are only built for tags, and the workflow will change a bit so we'll need to update:

the main RELEASING.md checklist,
this README.md
and update-pillow-tag.sh.

When releasing, we add and push a tag. It builds as normal (and also skips the "latest" jobs, we don't need to build/deploy them). The wheels are uploaded to a matching tag release here in this repo.

We can then download the wheels from the release, and can twine upload with the separately-built Windows wheels, and source (this looks handy for downloading).

(We could delete the release/files from here if we wanted to ensure PyPI is the place to go, not sure if that's necessary.)

Here's an example:

diff --git a/update-pillow-tag.sh b/update-pillow-tag.sh
index a48d6ca..c3000f1 100755
--- a/update-pillow-tag.sh
+++ b/update-pillow-tag.sh
@@ -15,4 +15,5 @@ git fetch --all
 git checkout $1
 cd ..
 git commit -m "Pillow -> $1" Pillow
-git push
+git tag "$1"
+git push --tags

Note we'd still need a normal git push (without --tags), but that will do a normal build of latest and non-latest (and no wheels), so that could come in the post-release thing, to avoid eating up CI time.

I'll annotate some lines too with some extra info.

hugovk · 2020-07-07T15:35:46Z

.travis.yml

-      - WHEELHOUSE_UPLOADER_USERNAME=travis-worker
-      # Following generated with
-      # travis encrypt -r python-pillow/pillow-wheels WHEELHOUSE_UPLOADER_SECRET=<the api key>
-      - secure: "ky76goiK6n4k8V9/uG340GSFVwmjE7G76l9xbhhGZkcph4eTwN5VRM/tqyJvlNs/HZOhKSILfyGBeaG8qf7gHmwr0touPT+EjWn4TNV8iyVj75ZshgRE9DuaIAfdH89gW2m+BmvBDyzi0JE3KVCu55NcGm8h7Ecl6nmQ/c2iROY="


Not needed, no longer using wheelhouse_uploader.

hugovk · 2020-07-07T15:36:18Z

.travis.yml

      os: osx
      osx_image: xcode9.3
      language: generic
+      if: tag IS blank


Prevent the latest jobs building for tag builds.

hugovk · 2020-07-07T15:36:42Z

.travis.yml

    - if [[ -n "$LATEST" ]]; then BUILD_COMMIT=master; fi
    - clean_code $REPO_DIR $BUILD_COMMIT
    - build_wheel $REPO_DIR $PLAT
+    - ls -l "${TRAVIS_BUILD_DIR}/wheelhouse/"


For info to confirm a wheel was built.

hugovk · 2020-07-07T15:38:08Z

.travis.yml

+deploy:
+  provider: releases
+  api_key:
+    secure: PTgVG7DrYa2FTSQOq0eDaHDZb1vy0vf6MulyuoXMg8rssPQgJ/mYxRpNDK4V0EKolpN7f8s/OGg+fpNNtp5pOCJGsx0Okcf+YB2ac+Xl7DQPBucbDKFXs1ndf/ny6umk0TXX8JTrDp/mJDJf401yx1+qsZ6X/PFvchXvXVrQ+SQ=


This is an encrypted OAuth token created using travis setup releases on my account when inside a local checkout of the https://github.com/python-pillow/pillow-wheels/ repo (ie. not my fork).

https://docs.travis-ci.com/user/deployment/releases/#authenticating-with-an-oauth-token

hugovk · 2020-07-07T15:38:22Z

.travis.yml

+  provider: releases
+  api_key:
+    secure: PTgVG7DrYa2FTSQOq0eDaHDZb1vy0vf6MulyuoXMg8rssPQgJ/mYxRpNDK4V0EKolpN7f8s/OGg+fpNNtp5pOCJGsx0Okcf+YB2ac+Xl7DQPBucbDKFXs1ndf/ny6umk0TXX8JTrDp/mJDJf401yx1+qsZ6X/PFvchXvXVrQ+SQ=
+  file_glob: true


So we can use *.whl in the next line.

hugovk · 2020-07-07T15:39:06Z

.travis.yml

+  file_glob: true
+  file: "${TRAVIS_BUILD_DIR}/${WHEEL_SDIR}/*.whl"
+  on:
+    condition: -z "$LATEST"


Redundant with if: tag IS blank, but a useful extra guard to make sure we don't build wheels for latest.

hugovk · 2020-07-07T15:39:23Z

.travis.yml

+  file: "${TRAVIS_BUILD_DIR}/${WHEEL_SDIR}/*.whl"
+  on:
+    condition: -z "$LATEST"
+    repo: python-pillow/pillow-wheels


This makes sure the deploy is only run from this repo.

hugovk · 2020-07-07T15:39:33Z

.travis.yml

+  on:
+    condition: -z "$LATEST"
+    repo: python-pillow/pillow-wheels
+    tags: true


And only for tags.

hugovk · 2020-07-07T15:40:17Z

.travis.yml

+    condition: -z "$LATEST"
+    repo: python-pillow/pillow-wheels
+    tags: true
+  skip_cleanup: true


Finally, tell Travis not to delete all the files, including wheels, before deploy.

https://docs.travis-ci.com/user/deployment#uploading-files-and-skip_cleanup

hugovk · 2020-07-07T15:45:27Z

And here's a test build on my fork (ignore the release is 7.2.1 and the files are 7.2.0, was just for test):

.travis.yml

Co-authored-by: Andrew Murray <[email protected]>

hugovk added 2 commits July 7, 2020 18:03

Upload wheels to GitHub Releases on tags

fc2896f

Only build latest when tag is blank

acf1912

hugovk mentioned this pull request Jul 7, 2020

Do not upload to rackspace #146

Closed

hugovk commented Jul 7, 2020

View reviewed changes

hugovk mentioned this pull request Jul 7, 2020

Provide wheels for pypy3 python-pillow/Pillow#4655

Closed

radarhere reviewed Aug 7, 2020

View reviewed changes

.travis.yml Outdated Show resolved Hide resolved

Use variable

6690682

Co-authored-by: Andrew Murray <[email protected]>

radarhere approved these changes Aug 7, 2020

View reviewed changes

radarhere merged commit d478f8b into python-pillow:master Aug 7, 2020

radarhere mentioned this pull request Aug 7, 2020

Updates for GitHub Releases #157

Merged

hugovk deleted the github-releases branch August 7, 2020 13:04

radarhere mentioned this pull request Aug 14, 2020

Updated PyPI instructions #158

Merged

hugovk mentioned this pull request Aug 26, 2020

wheels.scipy.org server not found multi-build/multibuild#349

Closed

hugovk mentioned this pull request Oct 15, 2023

Release Pillow 10.1.0 on October 15, 2023 python-pillow/Pillow#7348

Closed

21 tasks

hugovk mentioned this pull request Oct 23, 2023

Set up GitHub release token for Travis CI python-pillow/Pillow#7485

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upload wheels to GitHub Releases#156

Upload wheels to GitHub Releases#156
radarhere merged 3 commits intopython-pillow:masterfrom
hugovk:github-releases

hugovk commented Jul 7, 2020 •

edited

Loading

Uh oh!

hugovk Jul 7, 2020

Uh oh!

hugovk Jul 7, 2020

Uh oh!

hugovk Jul 7, 2020

Uh oh!

hugovk Jul 7, 2020

Uh oh!

hugovk Jul 7, 2020

Uh oh!

hugovk Jul 7, 2020

Uh oh!

hugovk Jul 7, 2020

Uh oh!

hugovk Jul 7, 2020

Uh oh!

hugovk Jul 7, 2020

Uh oh!

hugovk commented Jul 7, 2020 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

hugovk commented Jul 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hugovk commented Jul 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hugovk commented Jul 7, 2020 •

edited

Loading

hugovk commented Jul 7, 2020 •

edited

Loading