Merged
Conversation
Member
|
Please can you report the packaging error upstream? |
Member
Author
nulano
approved these changes
Jun 27, 2023
Contributor
nulano
left a comment
nulano
left a comment
There was a problem hiding this comment.
FWIW, the following would disable including test\CMakeLists.txt altogether:
"build": [
*cmds_cmake(
"tiff",
"-DBUILD_SHARED_LIBS:BOOL=OFF",
'-DCMAKE_C_FLAGS="-nologo -DLZMA_API_STATIC"',
+ "-Dtiff-tests:BOOL=OFF",
)
],However, I slightly prefer your patch since it makes it easier to test the libtiff build locally, although I don't think I've ever actually done that.
Co-authored-by: Ondrej Baranovič <[email protected]>
Member
Author
|
https://gitlab.com/libtiff/libtiff/-/issues/585 has been resolved by https://gitlab.com/libtiff/libtiff/-/merge_requests/519, and so should be part of the next libtiff release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libtiff 4.5.1 has been released - http://www.simplesystems.org/libtiff/
In https://download.osgeo.org/libtiff/tiff-4.5.1.tar.gz, test/CMakeLists.txt refers to test_write_read_tags.c, but that file is missing. It can be seen at https://gitlab.com/libtiff/libtiff/-/tree/master/test, so I presume this was a packaging error.
Since it is only a test, I've patched test/CMakeLists.txt in winbuild/build_prepare.py to remove the references to it.