Load image before performing size calculations in thumbnail()#6186
Merged
hugovk merged 1 commit intopython-pillow:mainfrom Apr 6, 2022
Merged
Load image before performing size calculations in thumbnail()#6186hugovk merged 1 commit intopython-pillow:mainfrom
hugovk merged 1 commit intopython-pillow:mainfrom
Conversation
radarhere
force-pushed
the
thumbnail_load
branch
from
8f1d959 to
96d9f3e
Compare
radarhere
force-pushed
the
thumbnail_load
branch
from
96d9f3e to
910a29f
Compare
This was referenced Mar 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps #6185
The TIFF in the issue has a tile orientation of 8, meaning that it is rotated and the size is changed in
load_end().However,
thumbnail()doesn't callload()before calculating the size that the image should become, so the calculations are incorrect. This is resolved by simply callingload()inthumbnail().