Skip to content

Allow converting an image to a numpy array to raise errors#5379

Merged
hugovk merged 1 commit intopython-pillow:masterfrom
radarhere:numpy
May 20, 2021
Merged

Allow converting an image to a numpy array to raise errors#5379
hugovk merged 1 commit intopython-pillow:masterfrom
radarhere:numpy

Conversation

@radarhere
Copy link
Copy Markdown
Member

@radarhere radarhere commented Apr 3, 2021

Resolves #5084

The following code runs without raising an error.

from PIL import Image
import numpy as np
im = Image.open("Tests/images/truncated_jpeg.jpg")
np.array(im)

Even though an OSError is raised if __array_interface__ is accessed directly.

from PIL import Image
im = Image.open("Tests/images/truncated_jpeg.jpg")
im.__array_interface__

This is a bug in numpy.

This PR works around that bug by replacing __array_interface__ with __array__.

@radarhere radarhere added the NumPy label Apr 3, 2021
@radarhere radarhere mentioned this pull request Apr 3, 2021
Closed
@hugovk hugovk added this to the 8.3.0 milestone Apr 3, 2021
@hugovk
Copy link
Copy Markdown
Member

hugovk commented Apr 3, 2021

Thanks for chasing up. Let's open an issue at NumPy as well?

https://gitter.im/numpy/numpy?at=6067b4ef3153ce63a3b6dcad says:

Its a bug, but I couldn't just rip the bandaid off it because of shapely. Should do that, but a PR to do a deprecation would be welcome also of course ;)

Maybe they won't have it deprecated and fixed by the next Pillow release in 3 months but let's at least give them a chance, and review this before release. I've added it to the 8.3.0 milestone.

@radarhere
Copy link
Copy Markdown
Member Author

radarhere commented Apr 3, 2021

Ok, raised at numpy/numpy#18723

@radarhere radarhere mentioned this pull request Apr 17, 2021
Closed
@radarhere radarhere mentioned this pull request May 1, 2021
Closed
@radarhere
Copy link
Copy Markdown
Member Author

radarhere commented May 19, 2021 •
edited
Loading

NumPy 1.21 will deprecate the error catching, raising a warning in this situation.

It is expected that NumPy 1.23, a year later, would start to raise an error.

@hugovk
Copy link
Copy Markdown
Member

hugovk commented May 20, 2021

Thanks for following up!

@hugovk hugovk merged commit 3cbf4d5 into python-pillow:master May 20, 2021
@radarhere radarhere deleted the numpy branch May 20, 2021 12:10
@t-vi t-vi mentioned this pull request Jul 1, 2021
Merged
This was referenced Nov 8, 2021
Closed
Closed
@radarhere
Copy link
Copy Markdown
Member Author

radarhere commented Feb 17, 2022

numpy/numpy#20835 has been merged into NumPy, so NumPy 1.23.should raise an error.

@radarhere radarhere mentioned this pull request Jun 24, 2022
Merged
@radarhere
Copy link
Copy Markdown
Member Author

radarhere commented Jun 24, 2022

NumPy 1.23 has been released, so I've created #6394 to revert this.

@radarhere radarhere mentioned this pull request Jul 9, 2022
Closed
@radarhere radarhere mentioned this pull request Sep 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

NumPy

Projects

None yet

Milestone

8.3.0

Development

Successfully merging this pull request may close these issues.

np.array(img) should not hide errors for corrupted images

2 participants

@radarhere @hugovk