Updated shell for mkdir commands#5219
Merged
hugovk merged 1 commit intopython-pillow:masterfrom Mar 8, 2021
Merged
Conversation
Member
|
I wonder if it failed due to using the |
Member
Author
|
If I do not specify the shell, then it fails the same. |
Member
Yes, let's go for this one. Thanks! |
radarhere
force-pushed
the
mkdir_test_errors
branch
from
436b0f1 to
666d3c5
Compare
Contributor
|
Checking the help documents for mkdir in cmd and powershell, I have found that |
Member
|
Good to know, thanks! This'll do for now :) |
radarhere
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently pushed a commit to GitHub Actions. It failed for a perfectly valid reason, but when failing, test-windows reported -
The '-p' flag is meant to prevent this error, but I guess this doesn't work on Windows (https://en.wikipedia.org/wiki/Mkdir#Options)
So instead, this PR replaces 'mkdir' with a Python command. It also changes test.yml, just for symmetry.
See https://github.com/radarhere/Pillow/runs/1751747364?check_suite_focus=true for my failing case combined with this commit to produce a correct 'Prepare to upload errors'