Added ImageDraw rounded_rectangle method#5208
Conversation
radarhere
force-pushed
the
rounded_rectangle
branch
from
dfc4265 to
16087b2
Compare
radarhere
force-pushed
the
rounded_rectangle
branch
4 times, most recently
from
1d17c8d to
16fe3a9
Compare
radarhere
force-pushed
the
rounded_rectangle
branch
from
16fe3a9 to
e340319
Compare
|
+1 for this PR, I like the idea. If it's not too slow I think we will use it in our YOLOv5 repo, as then we can achieve uniformity with our iOS app rectangles with rounded corners. |
radarhere
force-pushed
the
rounded_rectangle
branch
from
e340319 to
d1757e3
Compare
|
Please could you add this to the release notes? |
docs/reference/ImageDraw.rst
Outdated
| :param fill: Color to use for the fill. | ||
| :param width: The line width, in pixels. | ||
|
|
||
| .. versionadded:: 8.2.0 |
There was a problem hiding this comment.
Looks like this directive is applied to the width param:
Shall we move it up, similar to ImageDraw.textlength, to apply to the whole method?
There was a problem hiding this comment.
Did this get missed in the rebase?
There was a problem hiding this comment.
I don't believe so. I suspect if you refresh https://pillow--5208.org.readthedocs.build/en/5208/reference/ImageDraw.html again, it will work.
There was a problem hiding this comment.
Ah yes, refresh sorted it, thanks!
radarhere
force-pushed
the
rounded_rectangle
branch
from
c8dec79 to
9ce3eba
Compare
|
Ok, I've added release notes. |
3 participants
Resolves #4765 by adding
rounded_rectangle().Like
rectangle(),except with a
radiusargumentIn this implementation, I limit the radius of the corners so that it is not greater than half of the width or the height - so a rounded rectangle might be a circle, but not another ellipse.