Allow PixelAccess to use Python __int__ when parsing x and y#5206
Merged
hugovk merged 2 commits intopython-pillow:masterfrom Mar 31, 2021
Merged
Allow PixelAccess to use Python __int__ when parsing x and y#5206hugovk merged 2 commits intopython-pillow:masterfrom
hugovk merged 2 commits intopython-pillow:masterfrom
Conversation
|
Thank you for making life easier! |
Member
|
Do we need to do anything on PyAccess for this? |
Member
Author
|
Testing, I find that PyAccess works without this PR. The following code produces no error. from PIL import Image
import numpy
Image.USE_CFFI_ACCESS = True
im = Image.open("Tests/images/hopper.png")
pix = im.load()
print(pix.__class__) # <class 'PIL.PyAccess._PyAccess32_3'>
pix[numpy.int32(1), numpy.int32(2)] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5048
The issue reports that
returns
This PR calls
__int__()on the object passed in, which should provide support for other kinds of objects as well.