Add AVIF plugin (decoder + encoder using libavif) #5201

fdintino · 2021-01-11T01:52:55Z

Resolves #7983

This adds support for AVIF encoding and decoding, including AVIF image sequences.

I've added tests, and integrated libavif into the windows, linux, and mac CI builds. I haven't done anything to integrate with the docker-images repo.

I chose libavif rather than libheif because the former has been embraced by AOMedia and it's what Chromium uses. Packaging support is spotty at the moment, but I expect that to change soon (currently it's in Debian testing, Fedora rawhide, Ubuntu hirsute, and Alpine edge).

A few notes on the implementation here:

The plugin currently only supports encoding 8-bit images, and all images are decoded to 8-bit RGB(A). I wasn't totally clear on how best to deal with higher bit depths (somewhat related issue: Add support for high bit depth multichannel images #1888)
The RGB to YUV conversion isn't exposed to python at all. Chroma subsampling and the presence of an alpha channel make it non-trivial to return decoded images as YCbCr. It would not be difficult to permit encoding from a YCbCr source.
Since there isn't a way to pass parameters to Image.open (Parameters for Image.open() #569), I'm using module globals in AvifImagePlugin.py to make decoder codec choice and chroma upsampling configurable. I suspect there's a better way to do this.

The star.avifs test file is licensed as CC-BY

I linted the C code with the new clang-format settings, but made the following change so that it didn't make PyObject_HEAD and the threading macros look wonky:

diff --git a/.clang-format b/.clang-format
index be32e6d1..300f8e54 100644
--- a/.clang-format
+++ b/.clang-format
@@ -18,3 +18,7 @@ SpaceBeforeParens: ControlStatements
 SpacesInParentheses: false
 TabWidth: 4
 UseTab: Never
+StatementMacros:
+  - PyObject_HEAD
+  - Py_BEGIN_ALLOW_THREADS
+  - Py_END_ALLOW_THREADS

radarhere · 2021-01-11T02:21:53Z

Tests/helper.py

@@ -206,6 +207,7 @@ def _test_leak(self, core):
        start_mem = self._get_mem_usage()
        for cycle in range(self.iterations):
            core()
+            gc.collect()


Did you want to talk about why you added this?

I accidentally left this in here while I was debugging. I'll remove it.

Actually, I realized now why I added this: without it the leak tests are non-deterministic. I could pad the memory limit to counteract the fact that it may not have hit the gc generation threshold before it checks the memory, but forcing garbage collection after each iteration ensures that the test is deterministic.

This line has been moved into test_file_avif.py

wiredfool · 2021-01-11T20:17:46Z

src/_avif.c

+    }
+
+    avifRGBImageAllocatePixels(&rgb);
+    memcpy(rgb.pixels, rgb_bytes, size);


Please document in a comment that this is safe for r/w, and potentially add an explict check that the rgb_bytes/rgb.pixels is large enough.

wiredfool · 2021-01-11T20:20:51Z

src/_avif.c

+        return NULL;
+    }
+
+    memcpy(self->data, avif_bytes, size);


Document here as well.

I wasn't entirely sure what you wanted documented for this line. I added this, let me know if it's what you had in mind:

Pillow/src/_avif.c

Lines 484 to 485 in b84a8e0

// We need to allocate storage for the decoder for the lifetime of the object

// (avifDecoderSetIOMemory does not copy the data passed into it)

I was able to avoid a memcpy here by having PyArg_ParseTuple pass in a PyBytesObject and incrementing the reference in the new / decrementing in the dealloc. That also avoids an unnecessary malloc during decoding.

Realized it would probably be better to have you resolve these conversations, to confirm that the feedback has indeed been addressed.

wiredfool · 2021-01-11T20:29:01Z

src/_avif.c

+        return NULL;
+    }
+
+    size = rgb.rowBytes * rgb.height;


Is this guaranteed to not overflow, even in the face of invalid input?

libavif currently restricts images to a maximum of 2^28 pixels. If the dimensions are larger than 16384x16384 then the function that sets decoder->image->width and decoder->image->height fails. So I suppose that a 4-channel 16384x16384 8-bit image could overflow on a 32-bit platform. I'm not certain because the codecs used by libavif have their own overflow limit checks. For instance, dav1d enforces a maximum of 2^26 pixels on 32-bit systems. Should I add a check against PY_SSIZE_T_MAX to be sure? (edit: answering my own question and adding this check)

Added here

Pillow/src/_avif.c

Lines 619 to 622 in b84a8e0

if (rgb.height > PY_SSIZE_T_MAX / row_bytes) {

PyErr_SetString(PyExc_MemoryError, "Integer overflow in pixel size");

return NULL;

}

Basically, I'm the one who will get a CVE on this if there's a problem, and I'd like really clear guidelines about what the assumptions are for sizes of things and where they come from for dangerous operations like memset, malloc, and pointer reads/writes. This isn't so much for now, but a couple years down the line, things need to be clear. This will be fuzzed, this will be run under valgrind, so hopefully there won't be problems.

I've basically had to reverse engineer how SgiRleDecode works over the last month or so, and I'd like to be preventing that sort of experience in the future.

Does raising a MemoryError if rgb.height > PY_SSIZE_T_MAX / row_bytes (as I have in the latest PR push) suffice to address that concern?

.ci/install.sh

wiredfool · 2021-01-11T20:38:19Z

Tests/test_file_avif.py

+
+
+@skip_unless_feature("avif")
+class TestAvifLeaks(PillowLeakTestCase):


I'd prefer not iterating a leak test in the standard test suite, as that can be expensive from a time POV. It's ok for the initial cut, but I'd rather not have it long term.

Do we want to leave this in the test suite now, or rename it to, say, CheckAvifLeaks?

nulano · 2021-01-11T20:56:26Z

Adding libavif to MSYS2 fails to compile due to a few missing defines (AVIF_CHROMA_UPSAMPLING_AUTOMATIC, AVIF_CHROMA_UPSAMPLING_FASTEST, AVIF_CHROMA_UPSAMPLING_BEST_QUALITY): https://github.com/nulano/Pillow/runs/1683386633?check_suite_focus=true#step:5:77

fdintino · 2021-01-11T23:44:35Z

@nulano it looks like those defines were only added in libavif 0.8.3. I'll figure some #if version checks around their usage.

fdintino · 2021-01-12T15:55:15Z

@nulano Is it okay if I cherry-pick your MSYS commit into this PR?

nulano

@nulano Is it okay if I cherry-pick your MSYS commit into this PR?

Of course, cherry-pick away!

I have a few nitpicks for winbuild/build_prepare, I haven't looked at the rest yet.

winbuild/build_prepare.py

fdintino · 2021-01-18T17:23:25Z

@radarhere @wiredfool @nulano I think I've addressed all feedback (except for the requests for docs on building), but I've left it up to you all to resolve conversations (or not).

Is this PR generally on the right track? I've held off on writing docs until I've gotten a signal one way or the other.

fdintino · 2021-02-15T18:25:03Z

Since it's been a month since I asked my question without response, I'll try to reframe it as more specific questions that might be more answerable.

Is the general structure of this plugin acceptable? I tried to hew closely to the conventions elsewhere in the repo, so I assume so, but would appreciate confirmation.
Is the test coverage sufficient? The gaps are all in the error handling. I'd be happy to try to add test cases for those to make it more complete.
I'd appreciate feedback on the encoder settings. For instance: should yuv_format be renamed subsampling to be consistent with the Jpeg plugin? Should I offer a jpeg-like 0-100 quality setting that maps the min/max quantizer? (The colorist library has such a quality setting that still allows qmin/qmax as an advanced override option). Should I eliminate any options? (My vote would be to get rid of qmin_alpha and qmax_alpha).
What would you like to see, CI-wise, with this pull request? While waiting for feedback I worked on putting this plugin in its own package, which builds manylinux wheels in the same manner as the pillow-wheels repo. I setup builds for all the codecs supported by libavif, on all platforms, and also added cached dependencies (see pillow-avif-plugin-depends). That includes a crate vendor tarball for rav1e, as I've found crates.io to be too unreliable for frequent CI builds. Would you want to wait until this PR is wrapped up and merged before I opened a pull request against pillow-wheels?
- Note: I think licensing shouldn't be an issue for anything: AOM, rav1e, dav1d, SVT-AV1 and libyuv are all BSD-2 licensed, libgav1 is Apache, and they all are covered under the Alliance for Open Media Patent License.
- It might be overkill to include all codecs in the manylinux and windows wheels. In particular, SVT-AV1 is far from ready for prime-time. My recommendation would be to include AOM, dav1d, and rav1e by default. AOM, being the reference implementation, is the most complete and has the highest quality, while dav1d and rav1e are the fastest (setting aside SVT-AV1).

Tests/test_file_avif.py

radarhere · 2021-03-26T12:14:56Z

This might be a libavif bug, but I find that if I run this PR, libavif has stopped working for macOS.

https://github.com/radarhere/Pillow/runs/2201531959#step:8:1174

/Users/runner/work/Pillow/Pillow/depends/libavif-0.8.4/ext/libyuv/include/libyuv/row.h:750:5: error: 'LIBYUV_UNLIMITED_DATA' is not defined, evaluates to 0 [-Werror,-Wundef]
#if LIBYUV_UNLIMITED_DATA
^
1 error generated.

LIBYUV_UNLIMITED_DATA was a change introduced in libyuv in the last month - https://chromium.googlesource.com/libyuv/libyuv/+/ba033a11e3948e4b3%5E%21/#F2

wiredfool · 2021-03-28T13:53:16Z

We're going to need to add the required libraries to the docker images as well, and we're going to need to add these to the oss-fuzz builder to get fuzzer support.

Might as well make a PR to the Pillow-wheels for whatever needs to happen on build. That will also be potentially helpful for getting the dependencies into oss-fuzz.

radarhere · 2025-03-19T11:48:24Z

We're starting with a clean slate, so we have the opportunity to pick something modern-ish as a baseline.

CentOS and Amazon Linux don't have an libavif package
As I said, Ubuntu 22.04 has 0.9.3
Debian 12 has 0.11.1
Ubuntu 24.04 has 1.0.4
Alpine 3.21 has 1.0.4
Fedora 40 has 1.0.4
Arch has 1.2.0

In a vacuum, I like the idea of only starting with the stable version of 1.0.0.

hugovk · 2025-03-19T13:49:23Z

Yep, let's do 1.0.0.

fdintino · 2025-03-19T17:51:14Z

@radarhere Could you take a look at fdintino#28 and let me know if you are okay with its inclusion here? Thanks.

Co-authored-by: Andrew Murray <[email protected]>

Replace chimera-missing-pixi.avif and rgba10.heif with images derived from the pillow "hopper" test image.

hugovk · 2025-04-01T04:14:36Z

@fdintino Thank you very much for your work and your persistence! This will be in today's Pillow 11.2.0 release.

Stormheg · 2025-04-01T10:38:03Z

I've been quietly following this pull request since 2022 or so. Super excited to see this land in Pillow 😄

Congratulations to all involved - what an amazing effort! ❤️

hugovk · 2025-04-01T15:10:59Z

Hmm, the new avif .so file has made the wheels about 4 times bigger (~3 MB -> 13 MB per wheel, ~256 MB -> 1.1 GB per release), and we hit the PyPI project limit before the whole release could be uploaded:

#8722 (comment)

I've asked PyPI for an increase, but I wonder if we can do anything to make the wheels smaller? Let's continue in #8856.

wantehchang · 2025-04-01T21:09:33Z

@radarhere Andrew: I merged the libavif pull request AOMediaCodec/libavif#2723 yesterday. You should be able to remove your CMAKE_POLICY_VERSION_MINIMUM=3.5 workaround for libyuv's CMakeLists.txt problem with CMake 4.0.0 now.

radarhere · 2025-04-01T23:21:10Z

Thanks. I've tested it, and it's still required for now. I see that's in libavif main, so that's something to look forward to with the next libavif release.

wantehchang · 2025-04-01T23:37:53Z

@radarhere Ah, you are using a release tag of libavif. I will look into creating a libavif v1.2.2 patch release with the CMake 4.0.0 build fixes.

radarhere added the Enhancement label Jan 11, 2021

radarhere reviewed Jan 11, 2021

View reviewed changes

wiredfool requested changes Jan 11, 2021

View reviewed changes

fdintino requested a review from wiredfool January 12, 2021 15:53

nulano reviewed Jan 12, 2021

View reviewed changes

winbuild/build_prepare.py Outdated Show resolved Hide resolved

winbuild/build_prepare.py Outdated Show resolved Hide resolved

winbuild/build_prepare.py Outdated Show resolved Hide resolved

winbuild/build_prepare.py Outdated Show resolved Hide resolved

fdintino mentioned this pull request Jan 13, 2021

AVIF support thumbor/thumbor#1314

Closed

fdintino force-pushed the libavif-plugin branch from 7efcefc to 3ae762e Compare January 23, 2021 16:16

fdintino mentioned this pull request Jan 30, 2021

Fix memcpy/sizeof typo in avifImageCopy AOMediaCodec/libavif#483

Merged

fdintino force-pushed the libavif-plugin branch 3 times, most recently from b433571 to ff56a9c Compare February 24, 2021 03:54

japsu mentioned this pull request Mar 2, 2021

Replace WebP previews with AVIF con2/edegal#197

Open

2 tasks

radarhere reviewed Mar 26, 2021

View reviewed changes

Tests/test_file_avif.py Outdated Show resolved Hide resolved

radarhere reviewed Mar 26, 2021

View reviewed changes

Tests/test_file_avif.py Outdated Show resolved Hide resolved

radarhere mentioned this pull request Mar 26, 2021

Updated libavif to 0.9.0 fdintino/Pillow#1

Merged

fdintino force-pushed the libavif-plugin branch from a9b00e0 to 09567f6 Compare March 28, 2021 16:37

fdintino force-pushed the libavif-plugin branch 5 times, most recently from b851ca6 to 649f5f3 Compare April 12, 2021 12:44

This was referenced Apr 12, 2021

Add libavif dependencies python-pillow/pillow-depends#37

Open

Add libavif build python-pillow/pillow-wheels#193

Closed

radarhere force-pushed the libavif-plugin branch from 1a6d251 to 5da2113 Compare March 19, 2025 08:40

radarhere and others added 2 commits March 21, 2025 22:11

Merge branch 'main' into libavif-plugin

0732554

Remove support for libavif < 1.0.0

9ea5e3d

This was referenced Mar 21, 2025

Remove support for libavif < 1.0.0 fdintino/Pillow#30

Merged

fix: compiler errors in libavif < 1.0.0 fdintino/Pillow#27

Closed

radarhere and others added 2 commits March 21, 2025 13:32

Added get_codec_version() (#29)

fca6df2

Co-authored-by: Andrew Murray <[email protected]>

Merge branch 'radarhere-avif_1' into libavif-plugin

024a894

radarhere mentioned this pull request Mar 22, 2025

Temporarily disable rav1e in WIndows build fdintino/Pillow#31

Closed

radarhere and others added 2 commits March 25, 2025 11:37

Update rust (#33)

2ba9356

Co-authored-by: Andrew Murray <[email protected]>

Merge branch 'main' into libavif-plugin

fdc68e6

radarhere mentioned this pull request Mar 31, 2025

Disable libyuv on macOS fdintino/Pillow#34

Closed

Continue to build libyuv on macOS

9e63868

hugovk added this to the 11.2.0 milestone Mar 31, 2025

radarhere and others added 4 commits March 31, 2025 22:29

Added release notes

eff2680

Derive some avif test images from existing Pillow test images

fb096e1

Replace chimera-missing-pixi.avif and rgba10.heif with images derived from the pillow "hopper" test image.

Updated size

1276543

Continue to build libyuv on Linux

c8d0408

hugovk merged commit 7d50816 into python-pillow:main Apr 1, 2025
69 of 71 checks passed

hugovk mentioned this pull request Apr 1, 2025

Release Pillow 11.2.0 on April 1, 2025 #8722

Open

14 tasks

cgohlke mentioned this pull request Apr 1, 2025

Reduce AVIF wheel size? #8856

Open

fdintino mentioned this pull request Apr 2, 2025

fix: use only aomenc and dav1d AVIF codecs to decrease wheel size #8858

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add AVIF plugin (decoder + encoder using libavif) #5201

Add AVIF plugin (decoder + encoder using libavif) #5201

fdintino commented Jan 11, 2021 •

edited by radarhere

Loading

radarhere Jan 11, 2021

fdintino Jan 11, 2021

fdintino Jan 12, 2021 •

edited

Loading

radarhere Dec 26, 2024 •

edited

Loading

wiredfool Jan 11, 2021

wiredfool Jan 11, 2021

fdintino Jan 12, 2021

fdintino Jan 23, 2021

fdintino Sep 24, 2023

wiredfool Jan 11, 2021

fdintino Jan 12, 2021 •

edited

Loading

fdintino Jan 12, 2021

wiredfool Jan 12, 2021

fdintino Jan 12, 2021

wiredfool Jan 11, 2021

hugovk Mar 18, 2025

nulano commented Jan 11, 2021

fdintino commented Jan 11, 2021

fdintino commented Jan 12, 2021

nulano left a comment

fdintino commented Jan 18, 2021

fdintino commented Feb 15, 2021 •

edited

Loading

radarhere commented Mar 26, 2021 •

edited

Loading

wiredfool commented Mar 28, 2021

radarhere commented Mar 19, 2025

hugovk commented Mar 19, 2025

fdintino commented Mar 19, 2025

hugovk commented Apr 1, 2025

Stormheg commented Apr 1, 2025

hugovk commented Apr 1, 2025

wantehchang commented Apr 1, 2025

radarhere commented Apr 1, 2025

wantehchang commented Apr 1, 2025

	// We need to allocate storage for the decoder for the lifetime of the object
	// (avifDecoderSetIOMemory does not copy the data passed into it)

	if (rgb.height > PY_SSIZE_T_MAX / row_bytes) {
	PyErr_SetString(PyExc_MemoryError, "Integer overflow in pixel size");
	return NULL;
	}



		@skip_unless_feature("avif")
		class TestAvifLeaks(PillowLeakTestCase):

Add AVIF plugin (decoder + encoder using libavif) #5201

Add AVIF plugin (decoder + encoder using libavif) #5201

Conversation

fdintino commented Jan 11, 2021 • edited by radarhere Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fdintino Jan 12, 2021 • edited Loading

Choose a reason for hiding this comment

radarhere Dec 26, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fdintino Jan 12, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nulano commented Jan 11, 2021

fdintino commented Jan 11, 2021

fdintino commented Jan 12, 2021

nulano left a comment

Choose a reason for hiding this comment

fdintino commented Jan 18, 2021

fdintino commented Feb 15, 2021 • edited Loading

radarhere commented Mar 26, 2021 • edited Loading

wiredfool commented Mar 28, 2021

radarhere commented Mar 19, 2025

hugovk commented Mar 19, 2025

fdintino commented Mar 19, 2025

hugovk commented Apr 1, 2025

Stormheg commented Apr 1, 2025

hugovk commented Apr 1, 2025

wantehchang commented Apr 1, 2025

radarhere commented Apr 1, 2025

wantehchang commented Apr 1, 2025

fdintino commented Jan 11, 2021 •

edited by radarhere

Loading

fdintino Jan 12, 2021 •

edited

Loading

radarhere Dec 26, 2024 •

edited

Loading

fdintino Jan 12, 2021 •

edited

Loading

fdintino commented Feb 15, 2021 •

edited

Loading

radarhere commented Mar 26, 2021 •

edited

Loading