Skip to content

Fix LCMS2 patch#4858

Merged
hugovk merged 2 commits intopython-pillow:masterfrom
nulano:winbuild-lcms2
Aug 13, 2020
Merged

Fix LCMS2 patch#4858
hugovk merged 2 commits intopython-pillow:masterfrom
nulano:winbuild-lcms2

Conversation

@nulano
Copy link
Contributor

@nulano nulano commented Aug 12, 2020

Fixes error from #4857:

had to modify winbuild\build\lcms2-2.11\Projects\VC2017\lcms2_static\lcms2_static.vcxproj to point to the installed windows SDK version (10.0.19041.0) for it to compile, but otherwise, everything worked fine

Also make sure all patches are actually applied to avoid this happening again.

@nulano
Copy link
Contributor Author

nulano commented Aug 12, 2020

GHA 3.9-dev jobs have now started failing due to #4784 with the release of 3.9-rc1.

@hugovk hugovk merged commit a34cc1d into python-pillow:master Aug 13, 2020
@hugovk
Copy link
Member

hugovk commented Aug 13, 2020

thanks!

@nulano nulano deleted the winbuild-lcms2 branch August 13, 2020 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants