Replaced distutils build_ext with setuptools#4829
Merged
hugovk merged 1 commit intopython-pillow:masterfrom Aug 3, 2020
Merged
Replaced distutils build_ext with setuptools#4829hugovk merged 1 commit intopython-pillow:masterfrom
hugovk merged 1 commit intopython-pillow:masterfrom
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps #4796
Replacing
with
At first, trying this fails with
_needs_stubis set infinalize_options()- https://github.com/pypa/setuptools/blob/145a78cdc1afb4ce0c0208ae86a00708eb79d27b/setuptools/command/build_ext.py#L162So we need to have all
Extensions created before runningfinalize_options. However, we useself.compilerto set some attributes ofExtensions, and that isn't set at the time offinalize_options().Instead, this PR suggests creating all
Extensions at the very beginning, and then updating or removing them inbuild_extensions().