Replaced distutils in test_image_access.py#4814
Merged
hugovk merged 2 commits intopython-pillow:masterfrom Jul 29, 2020
Merged
Conversation
Member
Author
|
In a move that's up for debate, I've added another commit, so that distutils is no longer explicitly imported - instead, I'm importing the distutils function from where it is imported in setuptools. |
radarhere
changed the title
Member
|
Thank you! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #4796, similar to #4809
Replaces
with
and
with
Also removes a
printstatement.However, this test is skipped on CIs, so this PR passing is not good evidence that my changes are correct. Instead, I created radarhere@73f8d40 to check that the values with and without distutils are the same - passing on AppVeyor and MSYS2 MINGW32.