Thanks @radarhere for lint fixes.

Not sure what's going on with MacOS builds and why they are failing. I don't have Mac in possession to test it first hand, so I tried enabling TRACE logs for TiffDecode and pushed them into separate branch under my form to see in GA where it crashes. Surprisingly it finished with no errors. So I don't have any ideas where to look.
Any help appreciated.

I've created PR kkopachev#2 to resolve the macOS exception

@radarhere Thank you for update, looks cleaner. I was trying to use higher-level language approach to swap pointer :)
I'm curious why original solution did not work. Any insights why it was failing?

No insights. If it was a simple mistake, then you would think it would be failing for more platforms than just macOS. I just found that ((*unpacker)[plane]) was where the error was being triggered, so I started trying alternatives and somewhere in there thought to remove the need for dereferencing entirely. So some of it was just trial and error using my macOS machine, some of it was using trial and error on GitHub Actions.

I want to review this before merge for safety. Not that I’ll catch everything but I want to make a pass on it.

I've added tests for new unpackers. Travis failure is unrelated.

Any updates here? Would love this to make it into release.

@wiredfool Do you think you'll have time to check this before release day?

Apparently not. It was on my list for last weekend, but I didn’t get to it.

Hey guys, any updates here?
@hugovk @kkopachev @wiredfool

@imfantuan Needs a rebase at least

Rebased.
I had to skip added tests for big endian system, following existing pattern.

This has major conflicts with a patch for a CVE that will be released in the next version.

See #5178

Rebased in #5178.