Replaced tiff_jpeg with jpeg compression when saving TIFF images#4627
Merged
hugovk merged 1 commit intopython-pillow:masterfrom Jun 20, 2020
Merged
Replaced tiff_jpeg with jpeg compression when saving TIFF images#4627hugovk merged 1 commit intopython-pillow:masterfrom
hugovk merged 1 commit intopython-pillow:masterfrom
Conversation
radarhere
changed the title
This was referenced Mar 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3786
In this issue, the user opens an image with 'tiff_jpeg' compression, and then tries to save it. libtiff throws an error though - 'OJPEGSetupEncode: OJPEG encoding not supported; use new-style JPEG compression instead.'
For a longer explanation of this error message, see the text at the beginning of the libtiff file that contains the error - https://gitlab.com/libtiff/libtiff/-/blob/master/libtiff/tif_ojpeg.c
According to https://www.awaresystems.be/imaging/tiff/tifftags/compression.html - 6 is old-style JPEG (Pillow tiff_jpeg compression), 7 is new-style JPEG (Pillow jpeg compression).
So this PR takes the advice from libtiff, and changes from 'tiff_jpeg' to 'jpeg' when saving.