Skip to content

Ensure that errors directory exists before trying to upload from it#4379

Merged
hugovk merged 1 commit intopython-pillow:masterfrom
radarhere:errors
Jan 26, 2020
Merged

Ensure that errors directory exists before trying to upload from it#4379
hugovk merged 1 commit intopython-pillow:masterfrom
radarhere:errors

Conversation

@radarhere
Copy link
Copy Markdown
Member

@radarhere radarhere commented Jan 25, 2020

Saw this in a failed test in #4378

2020-01-25T02:08:26.0031734Z ##[error]Process completed with exit code 1.
2020-01-25T02:08:26.0213052Z ##[group]Run actions/upload-artifact@v1
2020-01-25T02:08:26.0213188Z with:
2020-01-25T02:08:26.0213274Z   name: errors
2020-01-25T02:08:26.0213352Z   path: Tests/errors
2020-01-25T02:08:26.0213415Z env:
2020-01-25T02:08:26.0213494Z   pythonLocation: d:\a\Pillow\pypy3.6
2020-01-25T02:08:26.0213574Z ##[endgroup]
2020-01-25T02:08:26.2089374Z ##[error]Path does not exist d:\a\Pillow\Pillow\Tests\errors
2020-01-25T02:08:26.2448668Z ##[error]Exit code 1 returned from process: file name 'c:\runners\2.164.0\bin\Runner.PluginHost.exe', arguments 'action "GitHub.Runner.Plugins.Artifact.PublishArtifact, Runner.Plugins"'.
2020-01-25T02:08:26.2467880Z Cleaning up orphan processes

This PR fixes the error that the path does not exist, using mkdir -p.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 25, 2020 •
edited
Loading

Codecov Report

Merging #4379 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4379      +/-   ##
==========================================
- Coverage    90.7%   90.62%   -0.08%     
==========================================
  Files         324      324              
  Lines       38311    38104     -207     
  Branches     3184     3184              
==========================================
- Hits        34750    34532     -218     
+ Misses       3561     3543      -18     
- Partials        0       29      +29
Impacted Files Coverage Δ
src/_webp.c 70.39% <0%> (-8.83%) ⬇️
src/_imagingtk.c 76.92% <0%> (-7.7%) ⬇️
src/PIL/PyAccess.py 82.48% <0%> (-7.35%) ⬇️
Tests/test_lib_pack.py 94.25% <0%> (-5.75%) ⬇️
Tests/test_imagetk.py 96% <0%> (-4%) ⬇️
src/Tk/tkImaging.c 75.22% <0%> (-1.98%) ⬇️
src/map.c 31.77% <0%> (-0.96%) ⬇️
Tests/test_numpy.py 97.56% <0%> (-0.82%) ⬇️
src/libImaging/JpegDecode.c 80.76% <0%> (-0.72%) ⬇️
src/PIL/SpiderImagePlugin.py 84.65% <0%> (-0.57%) ⬇️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d33d467...b7dce81. Read the comment docs.

@radarhere
Copy link
Copy Markdown
Member Author

radarhere commented Jan 26, 2020

You might think that this should be rebased so that all the tests can pass. However, I'm more inclined to leave it failing from an unrelated error, as a demonstration that the change made here works.

@hugovk hugovk merged commit a64d0c9 into python-pillow:master Jan 26, 2020
@hugovk
Copy link
Copy Markdown
Member

hugovk commented Jan 26, 2020

It was good timing to get that error!

@radarhere radarhere deleted the errors branch January 26, 2020 09:32
@radarhere radarhere mentioned this pull request Jan 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@radarhere @hugovk