Skip to content

Add flags to Codecov for easier coverage checking/debugging#4378

Merged
radarhere merged 3 commits intopython-pillow:masterfrom
hugovk:codecov-flags
Jan 26, 2020
Merged

Add flags to Codecov for easier coverage checking/debugging#4378
radarhere merged 3 commits intopython-pillow:masterfrom
hugovk:codecov-flags

Conversation

@hugovk
Copy link
Copy Markdown
Member

@hugovk hugovk commented Jan 24, 2020

Changes proposed in this pull request:

image

cc @nulano @radarhere

@nulano
Copy link
Copy Markdown
Contributor

nulano commented Jan 24, 2020

I think this could be really useful. I just have two suggestions:

  • I would consider renaming the flag GHADocker to GHA_Docker (if that is possible), to make it easier to distinguish the CI and the platform. (The docs suggest the requirement is ^[a-z0-9_]{1,45}$)
  • Would it make sense to split GHA into GHA_MacOS and GHA_Ubuntu (perhaps with the matrix.include option)?

@hugovk
Copy link
Copy Markdown
Member Author

hugovk commented Jan 24, 2020

Good ideas, updated!

Build still in progress but shows:

image

https://codecov.io/gh/python-pillow/Pillow/src/070626d10ea9ecb4a26dc3d5d6336df6bde6b5aa/Tests/test_imageqt.py

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 24, 2020 •
edited
Loading

Codecov Report

Merging #4378 into master will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4378      +/-   ##
=========================================
- Coverage   90.38%   90.2%   -0.19%     
=========================================
  Files         324     324              
  Lines       38311   38381      +70     
  Branches     3184    3189       +5     
=========================================
- Hits        34628   34620       -8     
- Misses       3683    3758      +75     
- Partials        0       3       +3
Flag Coverage Δ
#AppVeyor 89.9% <ø> (?)
#GHA_Docker 85.71% <ø> (?)
#GHA_Ubuntu 88.16% <ø> (?)
#GHA_Windows 100% <ø> (?)
#GHA_macOS 100% <ø> (?)
#TravisCI 86.03% <ø> (?)
Impacted Files Coverage Δ
src/PIL/ImageGrab.py 51.11% <0%> (-46.67%) ⬇️
Tests/test_file_icns.py 78.75% <0%> (-20%) ⬇️
src/PIL/ImageShow.py 75.49% <0%> (-15.69%) ⬇️
src/PIL/IcnsImagePlugin.py 81.5% <0%> (-12%) ⬇️
src/PIL/PyAccess.py 82.48% <0%> (-7.35%) ⬇️
Tests/test_lib_pack.py 94.25% <0%> (-5.75%) ⬇️
src/PIL/BmpImagePlugin.py 94.52% <0%> (-3.36%) ⬇️
Tests/test_imagegrab.py 97.14% <0%> (-2.86%) ⬇️
src/PIL/ImImagePlugin.py 79.66% <0%> (-2.32%) ⬇️
src/PIL/XpmImagePlugin.py 89.28% <0%> (-1.79%) ⬇️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b626ea...5ac895e. Read the comment docs.

@radarhere radarhere mentioned this pull request Jan 25, 2020
Merged
@radarhere radarhere merged commit a0a9b76 into python-pillow:master Jan 26, 2020
@hugovk hugovk deleted the codecov-flags branch January 26, 2020 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Infrastructure Testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hugovk @nulano @radarhere