Merged
Conversation
Closed
radarhere
force-pushed
the
exif
branch
4 times, most recently
from
c6fc1cd to
a5b5da9
Compare
radarhere
force-pushed
the
exif
branch
2 times, most recently
from
aac5cfd to
4711c35
Compare
This was referenced Mar 5, 2019
radarhere
force-pushed
the
exif
branch
3 times, most recently
from
43363fc to
7ef4fad
Compare
hugovk
reviewed
Mar 30, 2019
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #520
In addition to the methods described in that issue, I have also added
get_ifd(), for reading specified subdirectories -Regarding #2081 -
MPO files can have EXIF data for separate images (Page 9 of http://www.cipa.jp/std/documents/e/DC-007_E.pdf). This PR changes
im.info["exif"]to be specific to the current MPO frame.Within the EXIF data of the second image in files in #2081, there is a Makernote EXIF tag containing parallax data. However, the MakerNote tag does not have consistent structure across MPO images - it is manufacturer specific. See https://www.awaresystems.be/imaging/tiff/tifftags/privateifd/exif/makernote.html and http://www.exiv2.org/makernote.html.
The issue provides Fujifilm MPO images. The specification of the Fujifilm MakerNote tag can be found at http://www.ozhiker.com/electronics/pjmt/jpeg_info/fujifilm_mn.html#Fujifilm_Tags, and the parallax tag value can be found at https://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/FujiFilm.html. I have added one of the images from the issue.
Within the test suite, there are Nintendo MPO images. See https://3dbrew.org/wiki/MPO and http://owl.phy.queensu.ca/~phil/exiftool/TagNames/Nintendo.html for information about their MakerNote tag.
The test added in this PR reads parallax data from both types of files.