Skip to content

Fix Travis CI: Only start Xvfb for Qt builds#3585

Merged
hugovk merged 3 commits intopython-pillow:masterfrom
hugovk:fix-travis
Jan 15, 2019
Merged

Fix Travis CI: Only start Xvfb for Qt builds#3585
hugovk merged 3 commits intopython-pillow:masterfrom
hugovk:fix-travis

Conversation

@hugovk
Copy link
Member

@hugovk hugovk commented Jan 15, 2019

WIP, fixes all build jobs except one: 2.7_with_system_site_packages Xenial.


Changes proposed in this pull request:

  • Only start Xvfb for Qt, and Qt is only available with the system site packages installs

Yesterday Travis CI released a new build image for Xenial:

https://changelog.travis-ci.com/ubuntu-xenial-16-04-build-environment-update-86123

Unfortunately that broke our Xenial builds. Trusty still works.

The Travis changelog says:

The Xenial build environment now comes with PhamtomJS2, a new way to define headless browser testing, via services: xvfb, and improved Java language support.

https://changelog.travis-ci.com/ubuntu-xenial-16-04-build-environment-update-86123

The update history says:

Xvfb init file is removed in favor of a systemd unit file. Xvfb can be set up with services: xvfb. The matching DISPLAY environment variable is made available when you do that.

https://docs.travis-ci.com/user/build-environment-updates/2019-01-14/


We need to find a way to start Xvfb on Xenial.

I tried with these but it didn't help [1] [2]:

    - python:  "2.7_with_system_site_packages" # For PyQt4
      name: "2.7_with_system_site_packages Xenial"
+      services: xvfb
services:
  - docker
+  - xvfb

@hugovk hugovk added the Build label Jan 15, 2019
@hugovk hugovk mentioned this pull request Jan 15, 2019
@hugovk
Copy link
Member Author

hugovk commented Jan 15, 2019

@radarhere figured out the other bits, thanks!

Merging.

@hugovk hugovk merged commit a478c21 into python-pillow:master Jan 15, 2019
@hugovk hugovk deleted the fix-travis branch January 15, 2019 14:16
@hugovk hugovk added the Qt Qt for Python, PyQt, PySide label Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build Qt Qt for Python, PyQt, PySide

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants