Adding missing mime types and extensions#3520
Merged
Conversation
radarhere
changed the title
Author
|
as is, it's actually wrong #3501 (review) |
for reference https://en.wikipedia.org/wiki/BMP_file_format https://en.wikipedia.org/wiki/ICO_(file_format) https://en.wikipedia.org/wiki/Pcx https://en.wikipedia.org/wiki/Netpbm_format https://en.wikipedia.org/wiki/.tga
Author
|
I think, in my noob mind, that this is now mergable as is. |
Member
|
This will need tests, similar to those in #3525. |
radarhere
reviewed
Mar 4, 2019
for reference https://en.wikipedia.org/wiki/BMP_file_format https://en.wikipedia.org/wiki/ICO_(file_format) https://en.wikipedia.org/wiki/Pcx https://en.wikipedia.org/wiki/Netpbm_format https://en.wikipedia.org/wiki/.tga
Member
|
I've just rebased this on master to include #3585, so that https://github.com/pirate486743186/Pillow/pull/2 would pass. |
hugovk
approved these changes
Mar 11, 2019
Added PNM to the list of PPM files
Member
|
My thoughts - the docs don't mention mime types. A commit has been added to update the documented list of PPM types, but there's no consistent documentation of file extensions. My instinct is that if something isn't documented, then a change doesn't need to be added to the release notes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for reference
https://en.wikipedia.org/wiki/BMP_file_format
https://en.wikipedia.org/wiki/ICO_(file_format)
https://en.wikipedia.org/wiki/Pcx
https://en.wikipedia.org/wiki/Netpbm_format
https://en.wikipedia.org/wiki/.tga
there's also "image/x-ms-bmp"