Add several TIFF decoders and encoders#268
Merged
aclark4life merged 2 commits intopython-pillow:masterfrom Jul 1, 2013
megabuz:master
Merged
Add several TIFF decoders and encoders#268aclark4life merged 2 commits intopython-pillow:masterfrom megabuz:master
aclark4life merged 2 commits intopython-pillow:masterfrom
megabuz:master
Conversation
Member
|
Any risks merging this? |
Author
|
i can't find libtiff release notes, so i don't know when they add this compressions types, but i think, it is old functionality |
Author
|
Found release notes, everything ok. I don't see any risk |
aclark4life
added a commit
that referenced
this pull request
Jul 1, 2013
Add several TIFF decoders and encoders
Member
|
Thanks all |
Member
|
The only danger I can see is that some of the full color tiff compressions can have an awful lot of data behind them, and when going from an in-memory string, it's an all at once thing. So, memory exhaustion could be an issue. (Also, might want to check on some signed/unsigned things, I'm not sure if there will be issues if we get something that's over 2 gig uncompressed) |
radarhere
pushed a commit
to radarhere/Pillow
that referenced
this pull request
Sep 24, 2023
Use Python 3.10 for setup-python
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libtiff can work with many tiff compressions, such as deflate, adobe deflate, sgilog and others. So we can add this functionality such as group4 decoder/encoder