Fix Image.fromarray with NumPy arrays: Supersedes PR #224#225
Merged
aclark4life merged 3 commits intopython-pillow:masterfrom May 23, 2013
Merged
Fix Image.fromarray with NumPy arrays: Supersedes PR #224#225aclark4life merged 3 commits intopython-pillow:masterfrom
aclark4life merged 3 commits intopython-pillow:masterfrom
Conversation
Image.fromarray attempts to call a method called `tobytes()` on the passed in object, but NumPy arrays don't have a `tobytes()` method, they have a `tostring()` method. (See http://docs.scipy.org/doc/numpy/reference/generated/numpy.ndarray.tostring.html). I think this was changed accidentally in a Python 3 compatibility update in which this call was confused with the `tobytes` and `frombytes` methods of Image objects.
ghost
assigned
Contributor
|
👍 |
aclark4life
added a commit
that referenced
this pull request
May 23, 2013
Fix Image.fromarray with NumPy arrays: Supersedes PR #224
radarhere
pushed a commit
to radarhere/Pillow
that referenced
this pull request
Sep 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes the commits from #224, and an extra ducktyping check to call the right method on image objects.