Merged
Conversation
|
Changes Unknown when pulling 5756321 on uploadcare:cleanup-transforms into * on python-pillow:master*. |
add section cookie for affine_fixed
float-point value of radians which cos will exactly 0.
rename to ImagingGenericTransform
Member
Author
|
rebased |
PIL/Image.py
Outdated
| data = (xs, 0, x0 + xs/2, 0, ys, y0 + ys/2) | ||
|
|
||
| elif method == PERSPECTIVE: | ||
| # change argument order to match implementation |
Member
There was a problem hiding this comment.
This comment doesn't apply anymore, right?
Member
Author
|
Links to commits in the description are updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal transform API was very confusing. For example,
rotatemethod was callingself.transformorself.im.rotatedepends onexpandargument, butself.im.rotateinternally also callsImagingTransformAffine, so it was excessive.Changes proposed in this pull request:
transposeoperations if it is possible regardless of filter. 8203a43cos(90°)now is exactly 0, not 6.123e-17. 7687ce8Image.rotatealways usesself.transform, soim.rotatewas removed from core library. 709078e 1f8c252ImagingTransformAffine,ImagingTransformPerspectiveandImagingTransformQuadwas replaced with one entry point to all transformations:ImagingTransform. FormerImagingTransformwas renamed toImagingGenericTransformand removed from extern symbols (Imaging.hfile). 6be3df2 9902d2e